New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First release of E2E #92

Merged
merged 16 commits into from Jan 9, 2018

Conversation

Projects
None yet
3 participants
@tobiasKaminsky
Member

tobiasKaminsky commented Sep 27, 2017

This is the first release to support end to end encryption.
Server app is needed: https://github.com/nextcloud/end_to_end_encryption

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@AndyScherzinger

This comment has been minimized.

Show comment
Hide comment
@AndyScherzinger

AndyScherzinger Nov 6, 2017

Member

Only minor comments, only thing I am unsure about is if the e.printStackTrace(); statements should be removed.

Member

AndyScherzinger commented Nov 6, 2017

Only minor comments, only thing I am unsure about is if the e.printStackTrace(); statements should be removed.

@tobiasKaminsky tobiasKaminsky referenced this pull request Dec 20, 2017

Closed

First release of E2E #1598

10 of 12 tasks complete
PARAM_SINGLE_COOKIE_HEADER, // to avoid problems with some web servers
PARAM_SINGLE_COOKIE_HEADER_VALUE);
getParams().setParameter(HttpMethodParams.USER_AGENT, userAgent);
getParams().setParameter(PARAM_PROTOCOL_VERSION, HttpVersion.HTTP_1_1);

This comment has been minimized.

@mario

mario Jan 7, 2018

Member

Why 1.1?

@mario

mario Jan 7, 2018

Member

Why 1.1?

This comment has been minimized.

Show outdated Hide outdated src/com/owncloud/android/lib/resources/files/LockFileOperation.java
Show outdated Hide outdated src/com/owncloud/android/lib/resources/files/UnlockFileOperation.java
Show outdated Hide outdated src/com/owncloud/android/lib/resources/files/UpdateMetadataOperation.java
Show outdated Hide outdated src/com/owncloud/android/lib/resources/files/UpdateMetadataOperation.java
Show outdated Hide outdated src/com/owncloud/android/lib/resources/users/GetPrivateKeyOperation.java
Show outdated Hide outdated src/com/owncloud/android/lib/resources/users/GetPublicKeyOperation.java
Show outdated Hide outdated src/com/owncloud/android/lib/resources/users/SendCSROperation.java
Show outdated Hide outdated src/com/owncloud/android/lib/resources/users/SendCSROperation.java
Show outdated Hide outdated src/com/owncloud/android/lib/resources/users/StorePrivateKeyOperation.java

@tobiasKaminsky tobiasKaminsky referenced this pull request Jan 8, 2018

Closed

Release 3.0 - Roadmap #1884

52 of 57 tasks complete
@tobiasKaminsky

This comment has been minimized.

Show comment
Hide comment
@tobiasKaminsky

tobiasKaminsky Jan 8, 2018

Member

@mario thanks for the CR, I fixed everything and rebased the PR.

Member

tobiasKaminsky commented Jan 8, 2018

@mario thanks for the CR, I fixed everything and rebased the PR.

@mario

This comment has been minimized.

Show comment
Hide comment
@mario

mario Jan 9, 2018

Member

@tobiasKaminsky after you fix the two remaining things, feel free to merge. Good job! :)

👍

Approved with PullApprove

Member

mario commented Jan 9, 2018

@tobiasKaminsky after you fix the two remaining things, feel free to merge. Good job! :)

👍

Approved with PullApprove

tobiasKaminsky added some commits Aug 30, 2017

do not fail if permission is empty/null
correctly set user agent everywhere
@tobiasKaminsky

This comment has been minimized.

Show comment
Hide comment
@tobiasKaminsky

tobiasKaminsky Jan 9, 2018

Member

Merging with only one approval as @AndyScherzinger is on vacation.

Member

tobiasKaminsky commented Jan 9, 2018

Merging with only one approval as @AndyScherzinger is on vacation.

@tobiasKaminsky tobiasKaminsky merged commit fca8d44 into master Jan 9, 2018

2 of 3 checks passed

code-review/pullapprove Approval required by 1 of: AndyScherzinger, przybylski
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/drone/pr the build was successful
Details

@tobiasKaminsky tobiasKaminsky deleted the e2e branch Jan 9, 2018

@tobiasKaminsky tobiasKaminsky added this to the NC lib 1.0.34 milestone Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment