New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dismiss(DialogFragment) after pause/resume crashes #279

Closed
AndyScherzinger opened this Issue Sep 20, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@AndyScherzinger
Member

AndyScherzinger commented Sep 20, 2016

Steps to reproduce

  1. Enable the app passcode
  2. Open the share view and share a file/folder by link
  3. Minimize the app using the device main button with the share view in foreground
  4. Open again to the app

Actual behaviour

Passcode view is displayed and app crashes

Expected behaviour

Passcode view is displayed

Stack Trace

8-10 11:32:06.187 25328-25328/com.owncloud.android E/AndroidRuntime: FATAL EXCEPTION: main
  Process: com.owncloud.android, PID: 25328
  java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
      at android.support.v4.app.FragmentManagerImpl.checkStateLoss(FragmentManager.java:1489)
      at android.support.v4.app.FragmentManagerImpl.enqueueAction(FragmentManager.java:1507)
      at android.support.v4.app.BackStackRecord.commitInternal(BackStackRecord.java:634)
      at android.support.v4.app.BackStackRecord.commit(BackStackRecord.java:613)
      at android.support.v4.app.DialogFragment.dismissInternal(DialogFragment.java:201)
      at android.support.v4.app.DialogFragment.dismiss(DialogFragment.java:167)
      at com.owncloud.android.ui.activity.FileActivity.dismissLoadingDialog(FileActivity.java:934)
      at com.owncloud.android.ui.activity.FileActivity.onRemoteOperationFinish(FileActivity.java:753)
      at com.owncloud.android.ui.activity.ShareActivity.onRemoteOperationFinish(ShareActivity.java:220)
      at com.owncloud.android.utils.GetShareWithUsersAsyncTask.onPostExecute(GetShareWithUsersAsyncTask.java:94)
      at com.owncloud.android.utils.GetShareWithUsersAsyncTask.onPostExecute(GetShareWithUsersAsyncTask.java:44)
      at android.os.AsyncTask.finish(AsyncTask.java:651)
      at android.os.AsyncTask.access$500(AsyncTask.java:180)
      at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:668)
      at android.os.Handler.dispatchMessage(Handler.java:102)
      at android.os.Looper.loop(Looper.java:158)
      at android.app.ActivityThread.main(ActivityThread.java:7225)
      at java.lang.reflect.Method.invoke(Native Method)
      at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230)
      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120)

@tobiasKaminsky

This comment has been minimized.

Show comment
Hide comment
@tobiasKaminsky

tobiasKaminsky Sep 20, 2016

Member

What is the PR?

Member

tobiasKaminsky commented Sep 20, 2016

What is the PR?

@AndyScherzinger

This comment has been minimized.

Show comment
Hide comment
@AndyScherzinger

AndyScherzinger Sep 20, 2016

Member

it is in #281 - can also be shipped with 1.3.1 if we want to (I vote yes). I'll leave the decision with you :)

Member

AndyScherzinger commented Sep 20, 2016

it is in #281 - can also be shipped with 1.3.1 if we want to (I vote yes). I'll leave the decision with you :)

AndyScherzinger added a commit that referenced this issue Sep 20, 2016

AndyScherzinger added a commit that referenced this issue Sep 26, 2016

AndyScherzinger added a commit that referenced this issue Sep 26, 2016

AndyScherzinger added a commit that referenced this issue Oct 4, 2016

AndyScherzinger added a commit that referenced this issue Oct 4, 2016

tobiasKaminsky added a commit that referenced this issue Oct 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment