New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First release of E2E #1598

Closed
wants to merge 93 commits into
base: master
from

Conversation

Projects
None yet
10 participants
@tobiasKaminsky
Member

tobiasKaminsky commented Sep 27, 2017

This is the first release to support end to end encryption.
Server app is needed: https://github.com/nextcloud/end_to_end_encryption

TODO:

  • handle if folder is locked
    • during upload
    • during download: error message of server is displayed
  • handle interruption during upload
    • save metadata, unlock token
    • on retry upload file, metadata and then use unlock token
  • correct appending (2), (3) if files have the same name
  • Set new versionCode/VersionName for next release:
    versionCode="20010051"
    android:versionName="2.1.0-e2e-01
  • delete local keys on account removal
  • Test upgrade from
    • 2.0.0
    • first e2e version
  • disable logger prior merge in setup.xml

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 27, 2017

@leonklingele

This comment has been minimized.

Show comment
Hide comment
@leonklingele

leonklingele Sep 28, 2017

Member
Member

leonklingele commented Sep 28, 2017

@nextcloud nextcloud deleted a comment from codacy-bot Sep 28, 2017

tobiasKaminsky added some commits Jan 10, 2018

new line
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
move public method up, add doc
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
return RemoteOperationResult on error
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
remove printStacktrace()
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
replace printStacktrace() with Log_OC
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
new line
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

@nextcloud nextcloud deleted a comment from codacy-bot Jan 10, 2018

@nextcloud nextcloud deleted a comment from codacy-bot Jan 10, 2018

@nextcloud nextcloud deleted a comment from codacy-bot Jan 10, 2018

@nextcloud nextcloud deleted a comment from codacy-bot Jan 10, 2018

@nextcloud nextcloud deleted a comment from codacy-bot Jan 10, 2018

@nextcloud nextcloud deleted a comment from codacy-bot Jan 10, 2018

extract RSA/AES to static string
make final

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

@nextcloud nextcloud deleted a comment from codacy-bot Jan 10, 2018

@nextcloud nextcloud deleted a comment from codacy-bot Jan 10, 2018

@nextcloud nextcloud deleted a comment from codacy-bot Jan 10, 2018

@nextcloud nextcloud deleted a comment from codacy-bot Jan 10, 2018

}
@Override
public Dialog onCreateDialog(Bundle savedInstanceState) {

This comment has been minimized.

@codacy-bot
@codacy-bot

@nextcloud nextcloud deleted a comment from codacy-bot Jan 10, 2018

@nextcloud nextcloud deleted a comment from codacy-bot Jan 10, 2018

@SuppressLint("AndroidLintUseSparseArrays") // gson cannot handle sparse arrays easily, therefore use hashmap
@RequiresApi(api = Build.VERSION_CODES.KITKAT)
private RemoteOperationResult encryptedUpload(OwnCloudClient client, OCFile parentFile) {

This comment has been minimized.

return null;
}
private RemoteOperationResult normalUpload(OwnCloudClient client) {

This comment has been minimized.

@SuppressLint("AndroidLintUseSparseArrays") // gson cannot handle sparse arrays easily, therefore use hashmap
@RequiresApi(api = Build.VERSION_CODES.KITKAT)
private RemoteOperationResult encryptedUpload(OwnCloudClient client, OCFile parentFile) {

This comment has been minimized.

@codacy-bot
@codacy-bot
}
}
private void handleSuccessfulUpload(File temporalFile, File expectedFile, File originalFile,

This comment has been minimized.

return null;
}
private RemoteOperationResult normalUpload(OwnCloudClient client) {

This comment has been minimized.

@codacy-bot
@codacy-bot

@tobiasKaminsky tobiasKaminsky referenced this pull request Jan 10, 2018

Merged

E2E #1944

2 of 2 tasks complete
@tobiasKaminsky

This comment has been minimized.

Show comment
Hide comment
@tobiasKaminsky

tobiasKaminsky Jan 10, 2018

Member

I did a full rebase and opened up a new PR #1944 as I do not want to overwrite it here, in case something broke.
Closing it, but please do not delete until #1944 is merged.

Member

tobiasKaminsky commented Jan 10, 2018

I did a full rebase and opened up a new PR #1944 as I do not want to overwrite it here, in case something broke.
Closing it, but please do not delete until #1944 is merged.

@tobiasKaminsky tobiasKaminsky deleted the e2e branch Jan 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment