From d3b1a5db989a017209831ea36f04999d3aab35db Mon Sep 17 00:00:00 2001 From: alperozturk96 Date: Fri, 30 Jan 2026 11:06:10 +0100 Subject: [PATCH] fix(strings): file upload limit message Signed-off-by: alperozturk96 --- .../com/nextcloud/strings/StringsTests.kt | 37 +++++++++++++++++++ .../client/jobs/upload/FileUploadHelper.kt | 2 +- 2 files changed, 38 insertions(+), 1 deletion(-) create mode 100644 app/src/androidTest/java/com/nextcloud/strings/StringsTests.kt diff --git a/app/src/androidTest/java/com/nextcloud/strings/StringsTests.kt b/app/src/androidTest/java/com/nextcloud/strings/StringsTests.kt new file mode 100644 index 000000000000..3c939cd37958 --- /dev/null +++ b/app/src/androidTest/java/com/nextcloud/strings/StringsTests.kt @@ -0,0 +1,37 @@ +/* + * Nextcloud - Android Client + * + * SPDX-FileCopyrightText: 2026 Alper Ozturk + * SPDX-License-Identifier: AGPL-3.0-or-later + */ + +package com.nextcloud.strings + +import android.content.Context +import androidx.test.platform.app.InstrumentationRegistry +import com.nextcloud.client.jobs.upload.FileUploadHelper.Companion.MAX_FILE_COUNT +import com.owncloud.android.R +import org.junit.Assert.assertEquals +import org.junit.Before +import org.junit.Test + +class StringsTests { + + private lateinit var context: Context + + @Before + fun setup() { + context = InstrumentationRegistry.getInstrumentation().targetContext + } + + @Test + fun testMaxFileCountText() { + val message = context.resources.getQuantityString( + R.plurals.file_upload_limit_message, + MAX_FILE_COUNT, + MAX_FILE_COUNT + ) + + assertEquals(message, "You can upload up to 500 files at once.") + } +} diff --git a/app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadHelper.kt b/app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadHelper.kt index 62b3294b73af..809d24c8e66d 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadHelper.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadHelper.kt @@ -73,7 +73,6 @@ class FileUploadHelper { companion object { private val TAG = FileUploadWorker::class.java.simpleName - @Suppress("MagicNumber") const val MAX_FILE_COUNT = 500 val mBoundListeners = HashMap() @@ -501,6 +500,7 @@ class FileUploadHelper { fun showFileUploadLimitMessage(activity: Activity) { val message = activity.resources.getQuantityString( R.plurals.file_upload_limit_message, + MAX_FILE_COUNT, MAX_FILE_COUNT ) DisplayUtils.showSnackMessage(activity, message)