Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mockito-kotlin from 2.1.0 to 2.2.0 #4479

Conversation

@dependabot-preview
Copy link
Contributor

commented Sep 9, 2019

Bumps mockito-kotlin from 2.1.0 to 2.2.0.

Release notes

Sourced from mockito-kotlin's releases.

2.2.0

Commits
  • dbdef2f Merge pull request #353 from nhaarman/lenient
  • 8baf2db Support lenient in mock and withSettings
  • 442d227 Merge pull request #361 from nhaarman/update-build
  • 87a2043 Update Kotlin version to 1.3.50
  • 1e505f0 Actually test against multiple Kotlin versions
  • 4bcf696 Update README to include build instructions
  • ce6a747 Merge pull request #358 from BraisGabin/fix-matchers-test
  • 19470e0 Merge branch '2.x' into fix-matchers-test
  • d87150d Merge pull request #360 from BraisGabin/travis
  • 3f471b4 Fix travisCI
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@tobiasKaminsky

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

@dependabot rebase

Bumps [mockito-kotlin](https://github.com/nhaarman/mockito-kotlin) from 2.1.0 to 2.2.0.
- [Release notes](https://github.com/nhaarman/mockito-kotlin/releases)
- [Commits](nhaarman/mockito-kotlin@2.1.0...2.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/gradle/com.nhaarman.mockitokotlin2-mockito-kotlin-2.2.0 branch from 6e7a94b to ba56be1 Sep 9, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 9, 2019

Codecov Report

Merging #4479 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4479      +/-   ##
============================================
- Coverage     17.02%   16.99%   -0.04%     
  Complexity        3        3              
============================================
  Files           364      364              
  Lines         32065    32065              
  Branches       4515     4515              
============================================
- Hits           5460     5448      -12     
- Misses        25714    25723       +9     
- Partials        891      894       +3
Impacted Files Coverage Δ Complexity Δ
...om/owncloud/android/utils/FileSortOrderByName.java 14.28% <0%> (-2.86%) 0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java 79.76% <0%> (-2.39%) 0% <0%> (ø)
.../java/com/owncloud/android/utils/DisplayUtils.java 23.62% <0%> (-2.11%) 0% <0%> (ø)
...ncloud/android/ui/fragment/OCFileListFragment.java 25.71% <0%> (-0.41%) 0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java 35.58% <0%> (-0.19%) 0% <0%> (ø)
@nextcloud-android-bot

This comment has been minimized.

Copy link
Collaborator

commented Sep 9, 2019

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10867.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot

This comment has been minimized.

Copy link
Collaborator

commented Sep 9, 2019

@nextcloud-android-bot

This comment has been minimized.

Copy link
Collaborator

commented Sep 9, 2019

Codacy

275

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings141
Total429

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings141
Total429
@tobiasKaminsky tobiasKaminsky merged commit e8e66ba into master Sep 9, 2019
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/drone/pr Build is failing
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
DCO DCO
Details
fixupbot No fixup commits found. The commit history is clean 👍
Details
@tobiasKaminsky tobiasKaminsky deleted the dependabot/gradle/com.nhaarman.mockitokotlin2-mockito-kotlin-2.2.0 branch Sep 9, 2019
tobiasKaminsky added a commit that referenced this pull request Sep 10, 2019
863261b Merge pull request #4475 from nextcloud/photoSearchTask
e8e66ba Bump mockito-kotlin from 2.1.0 to 2.2.0 (#4479)
5a53ca3 check for nullable context stop task on pause
ba56be1 Bump mockito-kotlin from 2.1.0 to 2.2.0
572d63e Bump lifecycle-viewmodel-ktx from 2.0.0 to 2.1.0 (#4472)
0e95a07 Update findbugs-results.txt
7e40312 [tx-robot] updated from transifex
df7cb0c [tx-robot] updated from transifex
a212f1c daily dev 20190906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.