Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent upload from sensitive path #8433

Merged
merged 1 commit into from May 20, 2021
Merged

prevent upload from sensitive path #8433

merged 1 commit into from May 20, 2021

Conversation

tobiasKaminsky
Copy link
Member

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Testing

Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.

unit tests
instrumented tests
UI tests

  • Tests written, or not not needed

@tobiasKaminsky
prevent upload from sensitive path
97d6f29 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/8433.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

Lint

TypemasterPR
Warnings234234
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings51
Internationalization Warnings9
Multithreaded correctness Warnings9
Performance Warnings72
Security Warnings40
Dodgy code Warnings98
Total306

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings51
Internationalization Warnings9
Multithreaded correctness Warnings9
Performance Warnings72
Security Warnings40
Dodgy code Warnings98
Total306

AndyScherzinger
AndyScherzinger approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM while this also means no real feedback for the user, right?

@nextcloud-android-bot
Copy link
Collaborator

master-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Collaborator

master-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/1354-IT-master-06-16

LukasReschke
LukasReschke approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:i-trust-you:

@tobiasKaminsky tobiasKaminsky merged commit 8af3112 into master May 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the verifyLocalPath branch May 20, 2021 07:19
@tobiasKaminsky
Copy link
Member Author

/backport to stable-3.16

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 20, 2021
Merged
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.17.0 milestone May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasReschke LukasReschke LukasReschke approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.17.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tobiasKaminsky @nextcloud-android-bot @LukasReschke @AndyScherzinger