Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PendingIntents immutable #9726

Merged
merged 4 commits into from Jan 27, 2022
Merged

Make PendingIntents immutable #9726

merged 4 commits into from Jan 27, 2022

Conversation

AlvaroBrey
Copy link
Member

Good practice for security

  • Tests written, or not not needed

@AlvaroBrey
Copy link
Member Author

/backport to stable-3.19

@AlvaroBrey
Copy link
Member Author

/rebase

@AlvaroBrey AlvaroBrey force-pushed the fix/immutable-intents branch 6 times, most recently from d522236 to 374f27c Compare January 26, 2022 11:53
Álvaro Brey Vilas added 2 commits January 26, 2022 12:56
Good practice for security

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
This should be all of them. Picked up by lint.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
…ip ci]

Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
@github-actions
Copy link

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #9726 (d522236) into master (7eaed66) will decrease coverage by 0.87%.
The diff coverage is 0.00%.

Current head d522236 differs from pull request most recent head 4ac0baa. Consider uploading reports for the commit 4ac0baa to get more accurate results

@@            Coverage Diff             @@
##           master    #9726      +/-   ##
==========================================
- Coverage   31.49%   30.62%   -0.88%     
==========================================
  Files         505      505              
  Lines       38583    38589       +6     
  Branches     5381     5381              
==========================================
- Hits        12152    11816     -336     
- Misses      24581    24965     +384     
+ Partials     1850     1808      -42     
Impacted Files Coverage Δ
...extcloud/client/integrations/deck/DeckApiImpl.java 100.00% <ø> (ø)
...nextcloud/client/jobs/MediaFoldersDetectionWork.kt 16.90% <0.00%> (-0.49%) ⬇️
...java/com/nextcloud/client/jobs/NotificationWork.kt 0.00% <0.00%> (ø)
...n/java/com/nextcloud/client/media/PlayerService.kt 0.00% <0.00%> (ø)
...client/notifications/AppNotificationManagerImpl.kt 49.12% <0.00%> (ø)
...wncloud/android/files/services/FileDownloader.java 16.37% <0.00%> (-0.12%) ⬇️
.../owncloud/android/files/services/FileUploader.java 51.62% <ø> (ø)
.../owncloud/android/syncadapter/FileSyncAdapter.java 4.25% <0.00%> (ø)
...operations/RemoveRemoteEncryptedFileOperation.java 0.00% <0.00%> (-66.00%) ⬇️
.../java/com/nextcloud/client/jobs/OfflineSyncWork.kt 15.00% <0.00%> (-50.00%) ⬇️
... and 23 more

Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/9726.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

Lint

TypemasterPR
Warnings124102
Errors00

SpotBugs (new)

Warning Type Number
Bad practice Warnings 28
Correctness Warnings 82
Experimental Warnings 1
Internationalization Warnings 9
Malicious code vulnerability Warnings 57
Multithreaded correctness Warnings 9
Performance Warnings 68
Security Warnings 29
Dodgy code Warnings 358
Total 641

SpotBugs (master)

Warning Type Number
Bad practice Warnings 28
Correctness Warnings 82
Experimental Warnings 1
Internationalization Warnings 9
Malicious code vulnerability Warnings 57
Multithreaded correctness Warnings 9
Performance Warnings 68
Security Warnings 29
Dodgy code Warnings 358
Total 641

@nextcloud-android-bot
Copy link
Collaborator

@AlvaroBrey AlvaroBrey merged commit 4a29c2e into master Jan 27, 2022
15 of 16 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/immutable-intents branch January 27, 2022 08:16
@backportbot-nextcloud
Copy link

The backport to stable-3.19 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants