Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PIN lockout handling #9816

Merged
merged 5 commits into from Feb 15, 2022
Merged

Improve PIN lockout handling #9816

merged 5 commits into from Feb 15, 2022

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Feb 10, 2022

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

  • Tests written, or not not needed

@tobiasKaminsky
Copy link
Member Author

/rebase

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #9816 (df3c98a) into master (6b8ce02) will increase coverage by 28.22%.
The diff coverage is 35.59%.

@@              Coverage Diff              @@
##             master    #9816       +/-   ##
=============================================
+ Coverage      3.12%   31.35%   +28.22%     
=============================================
  Files           505      505               
  Lines         38592    38606       +14     
  Branches       5383     5384        +1     
=============================================
+ Hits           1207    12105    +10898     
+ Misses        37310    24691    -12619     
- Partials         75     1810     +1735     
Impacted Files Coverage Δ
src/main/java/com/owncloud/android/MainApp.java 57.96% <ø> (+57.00%) ⬆️
.../android/authentication/AuthenticatorActivity.java 37.63% <ø> (+35.08%) ⬆️
...owncloud/android/ui/activity/PassCodeActivity.java 0.00% <0.00%> (ø)
...owncloud/android/authentication/PassCodeManager.kt 32.69% <32.69%> (ø)
...c/main/java/com/nextcloud/client/core/ClockImpl.kt 80.00% <100.00%> (+5.00%) ⬆️
...c/main/java/com/nextcloud/client/di/AppModule.java 86.48% <100.00%> (+86.48%) ⬆️
...ui/fragment/contactsbackup/BackupListFragment.java 0.94% <0.00%> (+0.94%) ⬆️
...om/owncloud/android/utils/ErrorMessageAdapter.java 3.36% <0.00%> (+3.36%) ⬆️
...n/java/com/owncloud/android/utils/FileSortOrder.kt 77.77% <0.00%> (+3.70%) ⬆️
src/main/java/com/nextcloud/client/core/Task.kt 92.30% <0.00%> (+3.84%) ⬆️
... and 243 more

@tobiasKaminsky
Copy link
Member Author

/backport to stable-3.19

Álvaro Brey Vilas added 3 commits February 14, 2022 17:28
…tivity counter

This prevents repetition attacks

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
Prevents asking for pass immediately after setting it

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
…em clock directly

Improves testability

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
@nextcloud-android-bot
Copy link
Collaborator

Codacy

Lint

TypemasterPR
Warnings103103
Errors00

SpotBugs (new)

Warning Type Number
Bad practice Warnings 28
Correctness Warnings 82
Experimental Warnings 1
Internationalization Warnings 9
Malicious code vulnerability Warnings 57
Multithreaded correctness Warnings 9
Performance Warnings 68
Security Warnings 29
Dodgy code Warnings 358
Total 641

SpotBugs (master)

Warning Type Number
Bad practice Warnings 28
Correctness Warnings 82
Experimental Warnings 1
Internationalization Warnings 9
Malicious code vulnerability Warnings 57
Multithreaded correctness Warnings 9
Performance Warnings 68
Security Warnings 29
Dodgy code Warnings 358
Total 641

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/9816.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AlvaroBrey
Copy link
Member

@tobiasKaminsky please check if you're okay with the changes and merge whenever. I can't add you as a reviewer because you opened the PR initially.

@AlvaroBrey AlvaroBrey changed the title Pin: use activity paused also, as stopped is sometimes too slow Improve PIN lockout handling Feb 15, 2022
@tobiasKaminsky tobiasKaminsky merged commit 9723c04 into master Feb 15, 2022
18 checks passed
@AlvaroBrey AlvaroBrey added this to the Nextcloud App 3.20.0 milestone Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants