Skip to content

Conversation

@andrey18106
Copy link
Contributor

@andrey18106 andrey18106 requested a review from bigcat88 July 22, 2024 21:16
@bigcat88
Copy link
Member

swapping should only takes place when HaProxy is used and there should not be swap when "raw" socket is used.

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
@andrey18106 andrey18106 force-pushed the fix/ex-app-proxy/authentication-header-swap branch from 8698204 to d7a86f7 Compare July 22, 2024 21:24
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88 bigcat88 marked this pull request as ready for review July 23, 2024 09:51
Copy link
Member

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this applies only for remote installations(when using https and request to ExApp come throught DSP), regarding changes for docker-socket-proxy is here:

nextcloud/docker-socket-proxy#33

@bigcat88 bigcat88 merged commit 14fb2ff into main Jul 23, 2024
@bigcat88 bigcat88 deleted the fix/ex-app-proxy/authentication-header-swap branch July 23, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants