New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to login with email on imap #41

Merged
merged 4 commits into from Dec 8, 2017

Conversation

Projects
None yet
4 participants
@pierreozoux
Member

pierreozoux commented Nov 9, 2017

Fixes #40

It is my first php/Nextcloud PR, so be gentle :)

If you think we should put this behind an option, let me know.
Also, you have to keep in mind that this will create an entry in user_external, but you'll still have to delete manually the uid in user entry if you are migrating from normal user to imap user (in reference to #34).

@pierreozoux pierreozoux requested a review from MorrisJobke Nov 9, 2017

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Nov 9, 2017

Makes sense. Sadly I cannot test this.

cc @rullzer and @icewind1991 for some feedback on this as well.

@rullzer

This comment has been minimized.

Member

rullzer commented Nov 13, 2017

Yes makes sense. but also I have no easy way to test this quickly.

pierreozoux added some commits Dec 8, 2017

@pierreozoux

This comment has been minimized.

Member

pierreozoux commented Dec 8, 2017

Do you think we could get this merged before Nc13 is released?

Thanks a lot!

@MorrisJobke MorrisJobke merged commit f8fb4d9 into nextcloud:master Dec 8, 2017

1 of 2 checks passed

continuous-integration/drone/pr the build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone Dec 8, 2017

@umgfoin

SQL-quoting breaks imap-auth on Postgres.

@pierreozoux pierreozoux deleted the pierreozoux:imap-email branch Jan 19, 2018

@umgfoin

This comment has been minimized.

Contributor

umgfoin commented Jan 29, 2018

@MorrisJobke
As NC 13 release is approaching: Could somebody add a bug-label, here, otherwise commit f8fb4d9 will pass into stable breaking an official app in NC13 on Postgres.

Thanks,
umgfoin.

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Jan 29, 2018

As NC 13 release is approaching: Could somebody add a bug-label, here, otherwise commit f8fb4d9 will pass into stable breaking an official app in NC13 on Postgres.

🙈 Nobody really maintains this. And I totally have overseen that this is in our release :/

@rullzer @nickvergessen @icewind1991 Ideas?

@umgfoin

This comment has been minimized.

Contributor

umgfoin commented Jan 29, 2018

Nobody really maintains this.

No worries, nearly maintenance-free, sofar ;-)
PR pending - review required.

++umgfoin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment