-
Notifications
You must be signed in to change notification settings - Fork 148
add collaboration type #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Needs a description of what the tag actually does here in the docs: http://nextcloudappstore.readthedocs.io/en/latest/developer.html#info-xml See https://github.com/nextcloud/appstore/blob/master/docs/developer.rst As for the structure: the nesting seems a bit excessive given that you only want to be able to register search plugins. Maybe its possible to bring it down to something like (just some playing around, do not know the usecase enough for that): <collaboration>
<plugin type="search" sharing="SHARE_TYPE_CIRCLE">OCA\Circles\Collaboration\v1\CollaboratorSearchPlugin</plugin>
</collaboration> As for the share type: is there a finite number of types? If so, use an enumeration. |
also add some doc Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@BernhardPosselt ty! Your remarks are addressed |
Very small nitpick: XML and HTML usually uses an-attribute instead of anAttribute. Feel free to change it if you want to ;) |
Uff… did not pay attention to this. Perhaps, also because minOccurs, maxOccurs or xsi:noNamespaceSchemaLocation for instance do not follow this style as well. I acknowledge conventions and consistency however → will change this. |
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Depends on nextcloud/server#6328, used in nextcloud/circles#126
It looks fairly broad and complex… because "collaboration" is a pretty wide term and I've no idea what else could come there in future (or not).
shareType
(line 461) could be an enumeration as well, however it would mean naming constants here and have a coupling to code. Not sure this is necessary, but if worthwhile I can change this. Opinions welcome about it.