Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
add collaboration type #521
It looks fairly broad and complex… because "collaboration" is a pretty wide term and I've no idea what else could come there in future (or not).
Needs a description of what the tag actually does here in the docs: http://nextcloudappstore.readthedocs.io/en/latest/developer.html#info-xml
As for the structure: the nesting seems a bit excessive given that you only want to be able to register search plugins. Maybe its possible to bring it down to something like (just some playing around, do not know the usecase enough for that):
<collaboration> <plugin type="search" sharing="SHARE_TYPE_CIRCLE">OCA\Circles\Collaboration\v1\CollaboratorSearchPlugin</plugin> </collaboration>
As for the share type: is there a finite number of types? If so, use an enumeration.
referenced this pull request
Sep 26, 2017
Uff… did not pay attention to this. Perhaps, also because minOccurs, maxOccurs or xsi:noNamespaceSchemaLocation for instance do not follow this style as well. I acknowledge conventions and consistency however → will change this.