New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow personal settings via info.xml and doc links #547

Merged
merged 11 commits into from Feb 12, 2018

Conversation

Projects
None yet
3 participants
@nickvergessen
Copy link
Member

nickvergessen commented Feb 7, 2018

Allow personal settings via info.xml and doc links
Signed-off-by: Joas Schilling <coding@schilljs.com>

@nickvergessen nickvergessen added the bug label Feb 7, 2018

@nickvergessen nickvergessen requested a review from BernhardPosselt Feb 7, 2018

@@ -357,6 +364,10 @@
maxOccurs="unbounded"/>
<xs:element name="admin-section" type="php-class" minOccurs="0"
maxOccurs="unbounded"/>
<xs:element name="personal" type="php-class" minOccurs="0"

This comment has been minimized.

@nickvergessen

This comment has been minimized.

@BernhardPosselt

BernhardPosselt Feb 7, 2018

Member

also updating the docs would be nice https://github.com/nextcloud/appstore/blob/master/docs/developer.rst#app-metadata

E.g. what interface to implement or which base class to extend and what it does

This comment has been minimized.

@nickvergessen
@@ -242,6 +242,13 @@
</xs:restriction>
</xs:simpleType>

<xs:simpleType name="doc-url">
<xs:restriction base="xs:anyURI">
<xs:pattern value="(https://.+|(admin|user|developer)-[a-z]+[\-a-z]*[a-z]+)"/>

This comment has been minimized.

@nickvergessen

nickvergessen Feb 7, 2018

Member

Supported with 7+ 🙈

This comment has been minimized.

@BernhardPosselt

BernhardPosselt Feb 7, 2018

Member

base="xs:anyURI" is now wrong, should be base="non-empty-string"

This comment has been minimized.

@BernhardPosselt

BernhardPosselt Feb 7, 2018

Member

admin- prefix should probably only work in <admin> tags right?

This comment has been minimized.

@nickvergessen

nickvergessen Feb 8, 2018

Member

Well it's not enforced on server side, but yeah it's the case at the moment, so I guess we can do that.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 7, 2018

Coverage Status

Coverage remained the same at 97.566% when pulling 33b3a20 on update-schema-file into 15d5d59 on master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 7, 2018

Coverage Status

Coverage remained the same at 97.566% when pulling 33b3a20 on update-schema-file into 15d5d59 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 7, 2018

Coverage Status

Coverage increased (+0.006%) to 97.572% when pulling 5d25850 on update-schema-file into 19bb1d4 on master.

@@ -242,6 +242,13 @@
</xs:restriction>
</xs:simpleType>

<xs:simpleType name="doc-url">
<xs:restriction base="xs:anyURI">
<xs:pattern value="(https://.+|(admin|user|developer)-[a-z]+[\-a-z]*[a-z]+)"/>

This comment has been minimized.

@BernhardPosselt

BernhardPosselt Feb 7, 2018

Member

base="xs:anyURI" is now wrong, should be base="non-empty-string"

@@ -357,6 +364,10 @@
maxOccurs="unbounded"/>
<xs:element name="admin-section" type="php-class" minOccurs="0"
maxOccurs="unbounded"/>
<xs:element name="personal" type="php-class" minOccurs="0"

This comment has been minimized.

@BernhardPosselt

BernhardPosselt Feb 7, 2018

Member

also updating the docs would be nice https://github.com/nextcloud/appstore/blob/master/docs/developer.rst#app-metadata

E.g. what interface to implement or which base class to extend and what it does

@BernhardPosselt

This comment has been minimized.

Copy link
Member

BernhardPosselt commented Feb 7, 2018

I will take care of the tests and parsing. I suppose we just ignore non urls on the store?

BernhardPosselt added some commits Feb 7, 2018

@@ -242,6 +242,13 @@
</xs:restriction>
</xs:simpleType>

<xs:simpleType name="doc-url">
<xs:restriction base="xs:anyURI">
<xs:pattern value="(https://.+|(admin|user|developer)-[a-z]+[\-a-z]*[a-z]+)"/>

This comment has been minimized.

@BernhardPosselt

BernhardPosselt Feb 7, 2018

Member

admin- prefix should probably only work in <admin> tags right?

@nickvergessen

This comment has been minimized.

Copy link
Member

nickvergessen commented Feb 8, 2018

Btw, when you changed the info.xsd, please leave a note at nextcloud/server#8232 or update the file directly.

BernhardPosselt added some commits Feb 9, 2018

@BernhardPosselt

This comment has been minimized.

Copy link
Member

BernhardPosselt commented Feb 9, 2018

@nickvergessen adjusted the schema for you, now only needs docs

BernhardPosselt and others added some commits Feb 9, 2018

Add docs for personal and personal-section
Signed-off-by: Joas Schilling <coding@schilljs.com>

@BernhardPosselt BernhardPosselt merged commit a5cab9c into master Feb 12, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.006%) to 97.572%
Details

@BernhardPosselt BernhardPosselt deleted the update-schema-file branch Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment