Add pulse animation to assistant icon #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoambrosini
force-pushed
the
feature/359/animate-assistant-icon
branch
2 times, most recently
from
7efcec8 to
a2c11f8
Compare
|
Removed review request as icon size shrunk when I made the viewport bigger, looking for workaround |
Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me>
marcoambrosini
force-pushed
the
feature/359/animate-assistant-icon
branch
from
a2c11f8 to
a485671
Compare
|
Fixed the size issue, ready for review now |
marcelklehr
approved these changes
Sep 17, 2025
There was a problem hiding this comment.
Seems good to go then, right?
@marcoambrosini does it work gracefully when:
- focusing instead of hover
- stopping the hiver befire the animation is done (could just finish the animation)
- staying on hovering (either is fine: only animate once, or repeat as well)
|
@jancborchardt as of now focusing does not trigger the animation. Should I add it? |
|
@marcoambrosini I'd say generally we should treat hover and focus as close as possible, so yes. But it's not a blocker. |
|
Gave it a quick try and this is a bit complex. I will reference in new issue |
github-project-automation
bot
moved this from 🏗️ At engineering
to 🎉 Done
in 🖍 Design team
|
Do you want to add that to the NcAssistantIcon component of nextcloud/vue as well? |
|
That would result in this animation being in many other places right? I think it would be better to avoid that for now |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #359
Screen.Recording.2025-09-17.at.09.39.17.mov