New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirm() when deleting a calendar/event #341

Closed
georgehrke opened this Issue Feb 13, 2017 · 8 comments

Comments

@georgehrke
Member

georgehrke commented Feb 13, 2017

Yes, blocking modals suck, but right now there is no undo action. We are at a dead end with #148 and #149 and it will take at least another 2 or 3 months before nextcloud/server#1662 is implemented and released as stable.

A blocking modals still sucks less than accidentally loosing an entire calendar.

@raimund-schluessler

This comment has been minimized.

Show comment
Hide comment
@raimund-schluessler

raimund-schluessler Feb 13, 2017

Member

I know, @jancborchardt does not like modals, but maybe you want to have a look how the Tasks app does it: owncloud/tasks#354.

Member

raimund-schluessler commented Feb 13, 2017

I know, @jancborchardt does not like modals, but maybe you want to have a look how the Tasks app does it: owncloud/tasks#354.

@georgehrke

This comment has been minimized.

Show comment
Hide comment
@georgehrke

georgehrke Feb 13, 2017

Member

Really like that idea :)

Will probably use it here too.

Member

georgehrke commented Feb 13, 2017

Really like that idea :)

Will probably use it here too.

@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt Feb 14, 2017

Member

Ok … but I really hope we can gonforward with undo.

cc @nextcloud/javascript @ChristophWurst

Member

jancborchardt commented Feb 14, 2017

Ok … but I really hope we can gonforward with undo.

cc @nextcloud/javascript @ChristophWurst

@brantje

This comment has been minimized.

Show comment
Hide comment
@brantje

brantje Feb 16, 2017

Member

It's possible to replace the default confirm function with a more styled one.
Example here: http://jsfiddle.net/k5uDw/16/

Member

brantje commented Feb 16, 2017

It's possible to replace the default confirm function with a more styled one.
Example here: http://jsfiddle.net/k5uDw/16/

@skjnldsv

This comment has been minimized.

Show comment
Hide comment
@skjnldsv

skjnldsv Feb 16, 2017

Member

Careful, the undo on tasks doesn't fit the css guidelines!

Member

skjnldsv commented Feb 16, 2017

Careful, the undo on tasks doesn't fit the css guidelines!

@raimund-schluessler

This comment has been minimized.

Show comment
Hide comment
@raimund-schluessler

raimund-schluessler Feb 16, 2017

Member

Careful, the undo on tasks doesn't fit the css guidelines!

Yes, the implementation in the Tasks app is older than nextcloud/server#3024

Member

raimund-schluessler commented Feb 16, 2017

Careful, the undo on tasks doesn't fit the css guidelines!

Yes, the implementation in the Tasks app is older than nextcloud/server#3024

@georgehrke

This comment has been minimized.

Show comment
Hide comment
@georgehrke

georgehrke Feb 16, 2017

Member

doesn't fit the css guidelines

Can I find these guidelines somewhere? ;)

Member

georgehrke commented Feb 16, 2017

doesn't fit the css guidelines

Can I find these guidelines somewhere? ;)

@skjnldsv

This comment has been minimized.

Show comment
Hide comment
@skjnldsv

skjnldsv Feb 16, 2017

Member

@georgehrke nextcloud/server#2798
And https://docs.nextcloud.com/server/11/developer_manual/app/css.html

Not fully completed. Dev manual will be updated asap (need free time 😢 )

Member

skjnldsv commented Feb 16, 2017

@georgehrke nextcloud/server#2798
And https://docs.nextcloud.com/server/11/developer_manual/app/css.html

Not fully completed. Dev manual will be updated asap (need free time 😢 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment