New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color picker for the agendas #4

Closed
Spheerys opened this Issue Sep 17, 2016 · 7 comments

Comments

Projects
None yet
5 participants
@Spheerys

Spheerys commented Sep 17, 2016

Hi ,

Is it possible to replace the limited color chooser by a color picker ?

@tcitworld

This comment has been minimized.

Show comment
Hide comment
@tcitworld

tcitworld Oct 15, 2016

Member

Color input is now supported by over 70% of users, including Safari 10 users. Time to get this in ? http://caniuse.com/#feat=input-color

Member

tcitworld commented Oct 15, 2016

Color input is now supported by over 70% of users, including Safari 10 users. Time to get this in ? http://caniuse.com/#feat=input-color

@georgehrke

This comment has been minimized.

Show comment
Hide comment
@georgehrke

georgehrke Oct 15, 2016

Member

That means we would have to drop Safari9 support, but I'm fine with that. (ref #67)
Safari 10 is also available on older OS X releases like yosemite, so it's not a big deal.

Member

georgehrke commented Oct 15, 2016

That means we would have to drop Safari9 support, but I'm fine with that. (ref #67)
Safari 10 is also available on older OS X releases like yosemite, so it's not a big deal.

@tcitworld

This comment has been minimized.

Show comment
Hide comment
@tcitworld

tcitworld Oct 15, 2016

Member

iOS is still an issue though.

Member

tcitworld commented Oct 15, 2016

iOS is still an issue though.

@georgehrke

This comment has been minimized.

Show comment
Hide comment
@georgehrke

georgehrke Oct 15, 2016

Member

AFAIK we can check if the browser supports it with:

const input = document.createElement('input');
input.setAttribute('type', 'color');
if (input.type === 'color) => supported

So I suggest to only display the color picker when its supported, but don't provide a fallback.

Member

georgehrke commented Oct 15, 2016

AFAIK we can check if the browser supports it with:

const input = document.createElement('input');
input.setAttribute('type', 'color');
if (input.type === 'color) => supported

So I suggest to only display the color picker when its supported, but don't provide a fallback.

@Bullnados

This comment has been minimized.

Show comment
Hide comment
@Bullnados

Bullnados Mar 2, 2017

Is this feature in 1.5.1 like in changelog written or is that for Milestone 1.6.0?
I ask cause i haven't an advanced color picker.

Bullnados commented Mar 2, 2017

Is this feature in 1.5.1 like in changelog written or is that for Milestone 1.6.0?
I ask cause i haven't an advanced color picker.

@georgehrke

This comment has been minimized.

Show comment
Hide comment
@georgehrke

georgehrke Mar 2, 2017

Member

it only works in modern browsers, which one do you use?

Member

georgehrke commented Mar 2, 2017

it only works in modern browsers, which one do you use?

@Bullnados

This comment has been minimized.

Show comment
Hide comment
@Bullnados

Bullnados Mar 2, 2017

52.0 64bit FF
But it seems that was an adblock issue.
Disabling-->Reload-->New Picker
Also with adblock enabled new picker still visible 👍

Bullnados commented Mar 2, 2017

52.0 64bit FF
But it seems that was an adblock issue.
Disabling-->Reload-->New Picker
Also with adblock enabled new picker still visible 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment