IE11 support #329

Merged
merged 5 commits into from Feb 26, 2017

Conversation

Projects
None yet
5 participants
@georgehrke
Member

georgehrke commented Feb 3, 2017

No description provided.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 3, 2017

@georgehrke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @raghunayyar to be a potential reviewer.

@georgehrke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @raghunayyar to be a potential reviewer.

@tcitworld

This comment has been minimized.

Show comment
Hide comment
@tcitworld

tcitworld Feb 12, 2017

Member

Is it a demand of the NC guys enterprise subscriptions or are you a masochist ?

Member

tcitworld commented Feb 12, 2017

Is it a demand of the NC guys enterprise subscriptions or are you a masochist ?

@georgehrke

This comment has been minimized.

Show comment
Hide comment
@georgehrke

georgehrke Feb 12, 2017

Member

Yes, its customer related.

Member

georgehrke commented Feb 12, 2017

Yes, its customer related.

@georgehrke georgehrke changed the base branch from cleanup/js_minifying to master Feb 12, 2017

georgehrke added some commits Feb 2, 2017

add babel polyfill for ie11
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
refactor XMLUtility
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
adapt calendar and vevent services to new XMLUtility
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
fix calendar editor layout for ie11
Signed-off-by: Georg Ehrke <developer@georgehrke.com>

@georgehrke georgehrke requested a review from tcitworld Feb 20, 2017

@georgehrke

This comment has been minimized.

Show comment
Hide comment
@georgehrke

georgehrke Feb 20, 2017

Member

@tcitworld Can you please review? :)

You probably don't have an IE for testing around, but testing that everything still works in Firefox/Chromium would be awesome!

Member

georgehrke commented Feb 20, 2017

@tcitworld Can you please review? :)

You probably don't have an IE for testing around, but testing that everything still works in Firefox/Chromium would be awesome!

@tcitworld

This comment has been minimized.

Show comment
Hide comment
@tcitworld

tcitworld Feb 20, 2017

Member

Will try to boot a Windows device later today. :)

Member

tcitworld commented Feb 20, 2017

Will try to boot a Windows device later today. :)

@georgehrke

This comment has been minimized.

Show comment
Hide comment
@georgehrke

georgehrke Feb 20, 2017

Member

That would be awesome, thx! :)

Member

georgehrke commented Feb 20, 2017

That would be awesome, thx! :)

@georgehrke georgehrke changed the title from WIP - IE11 to IE11 support Feb 20, 2017

@georgehrke

This comment has been minimized.

Show comment
Hide comment
@georgehrke

georgehrke Feb 22, 2017

Member

@tcitworld any update yet? :)

Member

georgehrke commented Feb 22, 2017

@tcitworld any update yet? :)

@raimund-schluessler

This comment has been minimized.

Show comment
Hide comment
@raimund-schluessler

raimund-schluessler Feb 26, 2017

Member

With IE v11.576:

The view looks good, but the calendars are not loaded.

In the JS console:

stack"TypeError: Das Objekt unterstützt die Eigenschaft oder Methode "registerProtocolHandler" nicht ...

Call to http://192.168.56.2/nextcloud/remote.php/dav/calendars/admin/calendar-with-long-name/:
Request:

<c:calendar-query xmlns:NS1="" NS1:xmlns:a="http://apple.com/ns/ical/" xmlns:NS2="" NS2:xmlns:cs="http://calendarserver.org/ns/" xmlns:NS3="" NS3:xmlns:d="DAV:" xmlns:NS4="" NS4:xmlns:c="urn:ietf:params:xml:ns:caldav" xmlns:NS5="" NS5:xmlns:o="http://owncloud.org/ns" xmlns:NS6="" NS6:xmlns:n="http://nextcloud.com/ns"><d:prop><d:getetag /><c:calendar-data /></d:prop><c:filter><c:comp-filter name="VCALENDAR"><c:comp-filter name="VEVENT"><c:time-range start="20170129T230000Z" end="20170312T230000Z" /></c:comp-filter></c:comp-filter></c:filter></c:calendar-query>

Answer:

<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\Xml\LibXMLException</s:exception>
  <s:message>xmlns:NS1: Empty XML namespace is not allowed
 on line 1, column 28</s:message>
</d:error>
Member

raimund-schluessler commented Feb 26, 2017

With IE v11.576:

The view looks good, but the calendars are not loaded.

In the JS console:

stack"TypeError: Das Objekt unterstützt die Eigenschaft oder Methode "registerProtocolHandler" nicht ...

Call to http://192.168.56.2/nextcloud/remote.php/dav/calendars/admin/calendar-with-long-name/:
Request:

<c:calendar-query xmlns:NS1="" NS1:xmlns:a="http://apple.com/ns/ical/" xmlns:NS2="" NS2:xmlns:cs="http://calendarserver.org/ns/" xmlns:NS3="" NS3:xmlns:d="DAV:" xmlns:NS4="" NS4:xmlns:c="urn:ietf:params:xml:ns:caldav" xmlns:NS5="" NS5:xmlns:o="http://owncloud.org/ns" xmlns:NS6="" NS6:xmlns:n="http://nextcloud.com/ns"><d:prop><d:getetag /><c:calendar-data /></d:prop><c:filter><c:comp-filter name="VCALENDAR"><c:comp-filter name="VEVENT"><c:time-range start="20170129T230000Z" end="20170312T230000Z" /></c:comp-filter></c:comp-filter></c:filter></c:calendar-query>

Answer:

<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\Xml\LibXMLException</s:exception>
  <s:message>xmlns:NS1: Empty XML namespace is not allowed
 on line 1, column 28</s:message>
</d:error>
@georgehrke

This comment has been minimized.

Show comment
Hide comment
@georgehrke

georgehrke Feb 26, 2017

Member

you rebuild the sources with gulp, right?

Member

georgehrke commented Feb 26, 2017

you rebuild the sources with gulp, right?

@georgehrke

This comment has been minimized.

Show comment
Hide comment
@georgehrke

georgehrke Feb 26, 2017

Member

stack"TypeError: Das Objekt unterstützt die Eigenschaft oder Methode "registerProtocolHandler" nicht ...

That's fine. That's inside a try catch block

Member

georgehrke commented Feb 26, 2017

stack"TypeError: Das Objekt unterstützt die Eigenschaft oder Methode "registerProtocolHandler" nicht ...

That's fine. That's inside a try catch block

@raimund-schluessler

This comment has been minimized.

Show comment
Hide comment
@raimund-schluessler

raimund-schluessler Feb 26, 2017

Member

you rebuild the sources with gulp, right?

I am sorry. I used make, but since the build process is broken for me I forgot to manually build the JS file. After doing so the calendars are loading fine. I can edit the calendar (change color or name, etc.) and editing and creating events also works.

There are some small style issues, e.g. the icon for edit button is not visible, but in general it works well.
ie

you rebuild the sources with gulp, right?

I am sorry. I used make, but since the build process is broken for me I forgot to manually build the JS file. After doing so the calendars are loading fine. I can edit the calendar (change color or name, etc.) and editing and creating events also works.

There are some small style issues, e.g. the icon for edit button is not visible, but in general it works well.
ie

@raimund-schluessler

Besides small style issues it seems to work nicely. I propose to fix the styling issues in a separate PR.

@raimund-schluessler

This comment has been minimized.

Show comment
Hide comment
@raimund-schluessler

raimund-schluessler Feb 26, 2017

Member

Btw. make works fine. The reason for it to fail was insufficient memory of my Virtual Machine.

Btw. make works fine. The reason for it to fail was insufficient memory of my Virtual Machine.

@georgehrke

This comment has been minimized.

Show comment
Hide comment
@georgehrke

georgehrke Feb 26, 2017

Member

thx for testing :)

Member

georgehrke commented Feb 26, 2017

thx for testing :)

@georgehrke georgehrke merged commit 3daab57 into master Feb 26, 2017

3 checks passed

Scrutinizer 5 new issues, 2 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.003%) to 54.585%
Details

@georgehrke georgehrke deleted the feature/ie11 branch Feb 26, 2017

@raimund-schluessler raimund-schluessler referenced this pull request in nextcloud/tasks Jul 21, 2017

Open

IE11 : nothing appears #92

@jacestk

This comment has been minimized.

Show comment
Hide comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment