Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email validation and testing for appointments booking #4073

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

miaulalala
Copy link
Contributor

No description provided.

@miaulalala miaulalala added the 3. to review Waiting for reviews label Mar 15, 2022
@miaulalala miaulalala added this to the v3.3.0 milestone Mar 15, 2022
@miaulalala miaulalala self-assigned this Mar 15, 2022
@miaulalala
Copy link
Contributor Author

/backport to stable3.2

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Mar 15, 2022
lib/Controller/BookingController.php Outdated Show resolved Hide resolved
lib/Controller/BookingController.php Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #4073 (de312c9) into main (c4fe96d) will increase coverage by 0.24%.
The diff coverage is n/a.

❗ Current head de312c9 differs from pull request most recent head dc2be81. Consider uploading reports for the commit dc2be81 to get more accurate results

@@             Coverage Diff              @@
##               main    #4073      +/-   ##
============================================
+ Coverage     29.50%   29.75%   +0.24%     
- Complexity      324      325       +1     
============================================
  Files           220      220              
  Lines          7596     7600       +4     
  Branches       1003     1003              
============================================
+ Hits           2241     2261      +20     
+ Misses         5355     5339      -16     
Flag Coverage Δ
javascript 20.80% <ø> (-0.01%) ⬇️
php 68.83% <ø> (+1.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/store/calendarObjects.js 0.00% <0.00%> (ø)
...apps/calendar/lib/Controller/BookingController.php 55.55% <0.00%> (+21.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4fe96d...dc2be81. Read the comment docs.

Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala merged commit 09428f5 into main Mar 16, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/enhance-booking branch March 16, 2022 08:49
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request A backport was requested for this pull request label Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants