Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add booking email with ics attachment #4579

Merged
merged 1 commit into from Oct 11, 2022
Merged

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Oct 3, 2022

Fixes #3855

Before After
Subject: Your appointment "Have Lunch With Me" needs confirmation Subject: Your appointment "Have Lunch With Me" with admin needs confirmation
image image

New booking info email:
image

@miaulalala miaulalala added 3. to review Waiting for reviews enhancement New feature request papercut Annoying recurring issue with possibly simple fix. labels Oct 3, 2022
@miaulalala miaulalala self-assigned this Oct 3, 2022
@miaulalala
Copy link
Contributor Author

Maybe extend the text a bit... IDK, the text isn't very descriptive at the moment.

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 29.50% // Head: 29.84% // Increases project coverage by +0.34% 🎉

Coverage data is based on head (aa23053) compared to base (c1c574c).
Patch has no changes to coverable lines.

❗ Current head aa23053 differs from pull request most recent head cabc0f7. Consider uploading reports for the commit cabc0f7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4579      +/-   ##
============================================
+ Coverage     29.50%   29.84%   +0.34%     
- Complexity      330      338       +8     
============================================
  Files           220      220              
  Lines          7674     7719      +45     
  Branches       1002     1002              
============================================
+ Hits           2264     2304      +40     
- Misses         5410     5415       +5     
Flag Coverage Δ
javascript 20.57% <ø> (ø)
php 69.41% <ø> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../calendar/lib/Service/Appointments/MailService.php 98.03% <0.00%> (-1.97%) ⬇️
...lendar/lib/Service/Appointments/BookingService.php 82.05% <0.00%> (-1.95%) ⬇️
src/views/Appointments/Conflict.vue 0.00% <0.00%> (ø)
...lib/Service/Appointments/BookingCalendarWriter.php 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

lib/Service/Appointments/MailService.php Outdated Show resolved Hide resolved
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala
Copy link
Contributor Author

/rebase

@miaulalala miaulalala merged commit f265814 into main Oct 11, 2022
@miaulalala miaulalala deleted the enh/add-booking-info-email branch October 11, 2022 13:49
@JMoVS
Copy link

JMoVS commented Oct 11, 2022

@miaulalala nice work! But is there an option to skip the email verification step?

@miaulalala
Copy link
Contributor Author

@miaulalala nice work! But is there an option to skip the email verification step?

Hm it's a feature to think about maybe. But for now, no, there isn't. You can open a feature request on this repo, then we have that documented as a ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature request papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send event invitation to the person who booked an appointment
5 participants