Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow a calendar to be shared with circles. #602

Merged
merged 1 commit into from Mar 24, 2019
Merged

Allow a calendar to be shared with circles. #602

merged 1 commit into from Mar 24, 2019

Conversation

Reviewers

@ArtificialOwl ArtificialOwl

@skjnldsv skjnldsv

@rullzer rullzer

Assignees
No one assigned
Labels
2 - developing
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants
@viniciuscb @georgehrke @ArtificialOwl @wargreen @tcitworld @GoetheG @jmcclelland @dtygel @MorrisJobke
@viniciuscb
Copy link
Member

@viniciuscb viniciuscb commented Sep 14, 2017

The possibility to share a calendar with a circle is implemented in this commit and in commit e534c55 in nextcloud core.

There is a PR there:
nextcloud/server#6512

I've tested this functionality using nextcloud 12.
@viniciuscb viniciuscb mentioned this pull request Sep 14, 2017
Merged
@viniciuscb
Copy link
Member Author

@viniciuscb viniciuscb commented Sep 14, 2017

@dtygel

@georgehrke
Copy link
Member

@georgehrke georgehrke commented Sep 24, 2017

please review @daita

@georgehrke georgehrke requested a review from ArtificialOwl Sep 24, 2017
@georgehrke
Copy link
Member

@georgehrke georgehrke commented Sep 24, 2017

Hey :)

Thx for your pull-request!
I cc'ed @daita who develops the circle app.

Can you please look into the failing unit tests?

@georgehrke
Copy link
Member

@georgehrke georgehrke commented Oct 18, 2017

@daita @viniciuscb What's the status on this? :)

@ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Oct 18, 2017

Looks like it works, having some GUI issue:

selection_087

but it works

@ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Oct 18, 2017

Remember that this will needs nextcloud/server#6512

@viniciuscb
Copy link
Member Author

@viniciuscb viniciuscb commented Nov 30, 2017

Hi @daita , progress in this review? What should I do to have this accepted?

@georgehrke georgehrke mentioned this pull request Jan 4, 2018
Closed
@wargreen
Copy link

@wargreen wargreen commented Jan 18, 2018

hi,
Is it some news or WIP about this feature, or is it delayed to NC14 ?

@tcitworld
Copy link
Member

@tcitworld tcitworld commented Jan 19, 2018

It is since it needs some server changes.

@sunjam sunjam mentioned this pull request May 4, 2018
Closed
@GoetheG
Copy link

@GoetheG GoetheG commented May 17, 2018

Hey guys. Really great that you are working on that! Really looking forward to seeing your progress soon. Your contribution is one more step towards a real collaboration platform.

Cheers

@jmcclelland
Copy link

@jmcclelland jmcclelland commented Feb 3, 2019

Is there any update on this issue? Using circles with calendar would be a really useful feature.

@dtygel
Copy link

@dtygel dtygel commented Feb 6, 2019

Is there any update on this issue? Using circles with calendar would be a really useful feature.

We've been using this feature for more than a year in our NC implementation, already in NC14. Here, we're waiting for a review and guidelines to make it acceptable to be merged.

@georgehrke
Copy link
Member

@georgehrke georgehrke commented Feb 6, 2019

@dtygel Did you apply any changes to nextcloud/server#6512 or are you just using it like that?

@viniciuscb
Share calendar to a circle.
8b06038 
Changes in the interface to allow:

* Calendar to be shared with a circle
* Show calendars (and events) that are shared with current user's circles

This need that the commit f45624f1819833086368d95f0173bd55a3fb8dae is applied in nextcloud core.

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
@viniciuscb viniciuscb force-pushed the add_circles_share branch from 7183028 to 8b06038 Feb 7, 2019
@viniciuscb
Copy link
Member Author

@viniciuscb viniciuscb commented Feb 7, 2019

Using like that. Made a cherry-pick from previous commit and it worked in master. Made a new commit with current date and a more precise description. This and PR nextcloud/server#6512 were enough to allow a calendar to be shared with a circle.

@ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Mar 13, 2019

@georgehrke so, we will need a release of Calendar for NC16 including this PR. nextcloud/server#12119 will be merge also.

@ArtificialOwl ArtificialOwl mentioned this pull request Mar 13, 2019
Merged
@MorrisJobke MorrisJobke requested review from skjnldsv and rullzer Mar 13, 2019
@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Mar 13, 2019

@skjnldsv Mind to review this and release a new version of the app?

@georgehrke
Copy link
Member

@georgehrke georgehrke commented Mar 13, 2019

@MorrisJobke I will review and release this weekend

@georgehrke
Copy link
Member

@georgehrke georgehrke commented Mar 24, 2019

Works very well.

@viniciuscb Thank you for this pull-request. I'm happy to finally get this in.
I'm sorry it took so long.

@georgehrke georgehrke merged commit 55dcf35 into nextcloud:master Mar 24, 2019
2 of 3 checks passed
@sunjam sunjam mentioned this pull request Apr 25, 2019
Closed
@georgehrke georgehrke mentioned this pull request Oct 8, 2019
Closed
@GoetheG
Copy link

@GoetheG GoetheG commented Feb 8, 2020

Is this issue still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment