New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the collaborator search plugin #126

Merged
merged 4 commits into from Sep 15, 2017

Conversation

Projects
None yet
3 participants
@blizzz
Member

blizzz commented Sep 6, 2017

for NC 13, to have the sharee endpoint still provide circle results

add the collaborator search plugin
required for nextcloud/server#6328

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Sep 7, 2017

Member

get rid of this level? or what else is planned as type of collaboration?

Member

nickvergessen commented on appinfo/info.xml in 8a00033 Sep 7, 2017

get rid of this level? or what else is planned as type of collaboration?

This comment has been minimized.

Show comment
Hide comment
@blizzz

blizzz Sep 7, 2017

Member

Nothing is planned, this is just being prepared in case anything else comes some time in the future 💪

Member

blizzz replied Sep 7, 2017

Nothing is planned, this is just being prepared in case anything else comes some time in the future 💪

@daita

This comment has been minimized.

Show comment
Hide comment
@daita
Member

daita commented Sep 11, 2017

we would also need to update https://apps.nextcloud.com/schema/apps/info.xsd

daita added some commits Sep 11, 2017

moving to v1
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
not using Sharees anymore
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>

@daita daita merged commit 2a955d2 into master Sep 15, 2017

0 of 3 checks passed

continuous-integration/drone/pr the build failed
Details
continuous-integration/drone/push the build failed
Details
Scrutinizer Running
Details

@daita daita deleted the collaborator-search-plugin branch Sep 15, 2017

@blizzz

This comment has been minimized.

Show comment
Hide comment
@blizzz

blizzz Sep 15, 2017

Member

Wee, a bit fast 🚀 #6328 is not merged yet 🐌

Member

blizzz commented Sep 15, 2017

Wee, a bit fast 🚀 #6328 is not merged yet 🐌

@daita

This comment has been minimized.

Show comment
Hide comment
@daita

daita Sep 15, 2017

Member

not an issue as the old Sharees is still up & running !

Member

daita commented Sep 15, 2017

not an issue as the old Sharees is still up & running !

@blizzz blizzz referenced this pull request Sep 18, 2017

Merged

add collaboration type #521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment