Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FN field behaviour: first and last name #270

Closed
jonatoni opened this issue Jul 27, 2017 · 5 comments

Comments

Projects
4 participants
@jonatoni
Copy link
Member

commented Jul 27, 2017

When you try to add a new contact and you want to edit the name field there it's written by default "New contact" and you need to delete it in order to write the name of your contact.

Expected behaviour

Name field should be empty, in order to write the name of your contact.

Actual behaviour

At the field by default it is written "new contact" and to fill it you need to delete what is previously written there.

Server configuration

Contacts version: 1.5.4

@skjnldsv skjnldsv changed the title Contact field behaviour FN field behaviour: first and last name Jul 27, 2017

@jancborchardt jancborchardt added this to 💡 Possible issues in RailsGirls Summer of Code Aug 9, 2017

@jonatoni jonatoni moved this from 💡 Possible issues to 👩‍💻 In progress in RailsGirls Summer of Code Aug 10, 2017

@rutujasurve94

This comment has been minimized.

Copy link

commented Feb 19, 2018

I would like to take this bug up as a part of beginner level bug for Rails Girls Summer of Code 2018

@skjnldsv

This comment has been minimized.

Copy link
Member

commented Feb 19, 2018

@rutujasurve94 please do! :)
You can create a pr to fix this issue. and we'll review it!

@rutujasurve94

This comment has been minimized.

Copy link

commented Feb 19, 2018

Hi! @skjnldsv @jancborchardt I tried to look up the file in the contacts repo where "New Contact" is put as the default value for the FN field. But, a grep search didn't return any file. The fn field has been defined in the dav.js and contact.js file. Could you hint as to which file we could look up for finding this default behaviour so that we can convert this string to NULL to fix this issue?

@skjnldsv

This comment has been minimized.

Copy link
Member

commented Feb 20, 2018

You can't really set the FN field to null by default since a FN property is required by the vcard rfc :)
That's why there is a text by default, so the FN field isn't empty on creation.

Nonetheless, everything happens here: https://github.com/nextcloud/contacts/blob/master/js/services/contact_service.js#L226

@rutujasurve94

This comment has been minimized.

Copy link

commented Feb 20, 2018

I have raised a pull request here: #488
@skjnldsv @jancborchardt

@skjnldsv skjnldsv referenced this issue Aug 16, 2018

Merged

Contacts 3.0.0 #596

21 of 26 tasks complete

@skjnldsv skjnldsv added this to the 3.0.0 milestone Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.