New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When deleting an addressbook, no contact is selected if the group doesn't exist anymore #333

Closed
skjnldsv opened this Issue Sep 15, 2017 · 3 comments

Comments

Projects
5 participants
@skjnldsv
Member

skjnldsv commented Sep 15, 2017

We need to check if the $routeParams.gid exist in the group list.
If not, fallback to All contacts

@skjnldsv skjnldsv added this to the 2.0.1 milestone Sep 15, 2017

@Henni Henni removed the Hacktoberfest label Nov 1, 2017

@irgendwie irgendwie added the Hackweek label Nov 2, 2017

@irgendwie irgendwie removed the Hackweek label Jan 20, 2018

@skjnldsv skjnldsv modified the milestones: 2.1.1, 2.1.2 Mar 5, 2018

@arunikayadav42

This comment has been minimized.

arunikayadav42 commented Mar 13, 2018

Can I please start working on this issue :)

@jonatoni

This comment has been minimized.

Member

jonatoni commented Mar 14, 2018

@arunikayadav42 feel free to start working on this issue :)

@arunikayadav42

This comment has been minimized.

arunikayadav42 commented Mar 17, 2018

@jonatoni can you help me get started please, by pointing to the file that needs to be dealt with.I have already cloned the repo :)

@sleepypioneer sleepypioneer added this to 💡 Possible issues in Rails Girls Summer of Code 2018 via automation Jul 3, 2018

@suntala suntala moved this from 💡 Possible issues to 👩‍💻 In progress in Rails Girls Summer of Code 2018 Jul 10, 2018

Rails Girls Summer of Code 2018 automation moved this from 👩‍💻 In progress to 🎉 Done! Jul 20, 2018

skjnldsv added a commit that referenced this issue Jul 20, 2018

Merge pull request #579 from nextcloud/fixissue_333
Partial fix #333 - Select all contacts group when deleting last contact of a group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment