Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact groups messed up with upgrade toi 1.5.1 #63

Closed
brjhaverkamp opened this issue Dec 18, 2016 · 3 comments
Closed

Contact groups messed up with upgrade toi 1.5.1 #63

brjhaverkamp opened this issue Dec 18, 2016 · 3 comments
Assignees
Milestone

Comments

@brjhaverkamp
Copy link

@brjhaverkamp brjhaverkamp commented Dec 18, 2016

I upgraded the contacts app today from 1.4.0 to 1.5.1.
It seemed to have messed up my contact groups in a strange way.
Previously I had 2 groups: telephonebook and christmascard
now I have 4:
telephonebook
christmascard
telephonebook,christmascard
christmascard,telephonebook.

It seems the app is interpreting multiple Categories slightly differently.
This is likely due to escaping or not escaping the comma between the categories.

@zeehio

This comment has been minimized.

Copy link

@zeehio zeehio commented Dec 20, 2016

I can reproduce the bug as well.

The CATEGORIES field should be:

CATEGORIES:Category1,Category2

However it is:

CATEGORIES:Category1\,Category2

I can see this both in the contacts tab in my nextcloud 11 instance and also in the contacts app of my Android phone, syncing using DAVdroid.

@skjnldsv

This comment has been minimized.

Copy link
Member

@skjnldsv skjnldsv commented Dec 20, 2016

I think we should not escape groups and we should remove the ability to add coma in groups.

@zeehio

This comment has been minimized.

Copy link

@zeehio zeehio commented Dec 20, 2016

I have not tested categories with commas in them, my tests with multiple categories show that:

  • In the cards table, in the carddata column, commas that separate groups are escaped (and they should not be).

  • In the cards_properties table the CATEGORIES are separated by commas as expected.

Apparently the standard allows commas in category names stored as follows:

CATEGORIES:Category\,with\,commas,Category2
skjnldsv added a commit that referenced this issue Jan 3, 2017
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv added a commit that referenced this issue Jan 5, 2017
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 3. to review and removed 1. to develop labels Jan 26, 2017
@skjnldsv skjnldsv self-assigned this Jan 26, 2017
@irgendwie irgendwie closed this in da70db4 Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.