Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run SVGs through some sanitization #2407

Merged
merged 1 commit into from Sep 13, 2021
Merged

Run SVGs through some sanitization #2407

merged 1 commit into from Sep 13, 2021

Conversation

ChristophWurst
Copy link
Member

Better safe than sorry. And if they don't pass then we just display no photo. Good enough :)

@ChristophWurst ChristophWurst added the 3. to review Waiting for reviews label Aug 24, 2021
@ChristophWurst ChristophWurst self-assigned this Aug 24, 2021
@ChristophWurst ChristophWurst added this to TO REVIEW (max 4 PRs) in Christoph's Tasks via automation Aug 24, 2021
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #2407 (0e22b5c) into master (2d4f18b) will not change coverage.
The diff coverage is n/a.

Current head 0e22b5c differs from pull request most recent head 42430b2. Consider uploading reports for the commit 42430b2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2407   +/-   ##
=========================================
  Coverage     69.25%   69.25%           
  Complexity      247      247           
=========================================
  Files            21       21           
  Lines           696      696           
=========================================
  Hits            482      482           
  Misses          214      214           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d4f18b...42430b2. Read the comment docs.

Copy link
Member

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Christoph's Tasks automation moved this from TO REVIEW (max 4 PRs) to TO INTEGRATE Aug 25, 2021
@ChristophWurst ChristophWurst added the enhancement New feature or request label Sep 9, 2021
@ChristophWurst ChristophWurst force-pushed the verify-svgs branch 2 times, most recently from 55218f9 to d9ba33c Compare September 13, 2021 08:58
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@kesselb kesselb merged commit 019e1e0 into master Sep 13, 2021
19 checks passed
Christoph's Tasks automation moved this from TO INTEGRATE to DONE Sep 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the verify-svgs branch September 13, 2021 10:57
@ChristophWurst
Copy link
Member Author

/backport to stable4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants