fix(teams): restore selectedGroup on circle/user_group routes to fix "Unable to create contact" error (#5257)#5377
Open
pallavibakale wants to merge 1 commit into
Conversation
…"Unable to create contact" error (nextcloud#5257)
pallavibakale
changed the title
pallavibakale
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(teams): fix "Unable to create contact" error when a team is selected
RouterMixin.selectedGroup read only from
$route.params.selectedGroup, which is absent on circle and user_group routes after a routing refactor that moved them to dedicated paths. This caused selectedGroup to be undefined on team routes, breaking isCirclesView (always false) and making newContact() fall through to a router.push with a missing required param.Fix RouterMixin to derive selectedGroup from the route name when the param is absent. Update newContact() to check selectedCircle directly for the circle-specific event, extend the group-exclusion list to cover
ROUTE_CIRCLEandROUTE_USER_GROUP, and fall back toGROUP_ALL_CONTACTSwhen navigating from a user group view.Fixes #5257