New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial fix #333 - Select all contacts group when deleting last contact of a group #579

Merged
merged 1 commit into from Jul 20, 2018

Conversation

Projects
4 participants
@sleepypioneer
Member

sleepypioneer commented Jul 16, 2018

Partial fix #333 - Select all contacts group when deleting last contact of a group instead of showing no contacts page. Still displays 'contact not found' notification.

@sleepypioneer sleepypioneer added this to 👩‍💻 In progress in Rails Girls Summer of Code 2018 via automation Jul 16, 2018

@sleepypioneer sleepypioneer requested review from camilasan and skjnldsv Jul 16, 2018

@sleepypioneer sleepypioneer moved this from 👩‍💻 In progress to 🙋 Pull request to review in Rails Girls Summer of Code 2018 Jul 16, 2018

@codecov

This comment has been minimized.

codecov bot commented Jul 16, 2018

Codecov Report

Merging #579 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #579   +/-   ##
=======================================
  Coverage   15.87%   15.87%           
=======================================
  Files          62       62           
  Lines        1405     1405           
=======================================
  Hits          223      223           
  Misses       1182     1182
Impacted Files Coverage Δ
...s/components/contactList/contactList_controller.js 0.74% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3b1816...9bdaed8. Read the comment docs.

@skjnldsv

This comment has been minimized.

Member

skjnldsv commented Jul 19, 2018

Is this ready for reviews? Or are you planning to add more stuff? :)

@sleepypioneer

This comment has been minimized.

Member

sleepypioneer commented Jul 20, 2018

We'd like to have this code merged, as it fixes the problem of what contact is displayed however the small notification "Contact not found" at the top does still show so that would still need to be done before it's completely finished.

@skjnldsv skjnldsv merged commit da7438d into master Jul 20, 2018

3 checks passed

codecov/patch Coverage not affected when comparing d3b1816...9bdaed8
Details
codecov/project 15.87% remains the same compared to d3b1816
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Rails Girls Summer of Code 2018 automation moved this from 🙋 Pull request to review to 🎉 Done! Jul 20, 2018

@skjnldsv skjnldsv deleted the fixissue_333 branch Jul 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment