New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue settings addressbook popovermenu #618

Merged
merged 17 commits into from Sep 7, 2018

Conversation

Projects
2 participants
@sleepypioneer
Member

sleepypioneer commented Sep 4, 2018

Partial fix #614 working functions for Rename, Enable & Download.

Still needs some work:

  • after enabling addressbook popovermenu should stay open
  • styling of addressbook name (on the current app it is very light (0.3 opacity) would suggest 0.7 as we did for the sharee name

@sleepypioneer sleepypioneer added this to the 3.0.0 milestone Sep 4, 2018

@sleepypioneer sleepypioneer self-assigned this Sep 4, 2018

@sleepypioneer sleepypioneer added this to 👩‍💻 In progress in Rails Girls Summer of Code 2018 via automation Sep 4, 2018

@sleepypioneer sleepypioneer requested a review from skjnldsv Sep 4, 2018

@sleepypioneer

This comment has been minimized.

Member

sleepypioneer commented Sep 4, 2018

Still slightly concerned this contains the contacts.js file 😟

@skjnldsv

This comment has been minimized.

Member

skjnldsv commented Sep 4, 2018

@sleepypioneer delete it, git add the deleted file and commit again? :)

Show resolved Hide resolved src/components/Settings/SettingsAddressbook.vue
Show resolved Hide resolved src/components/Settings/SettingsAddressbook.vue Outdated
Show resolved Hide resolved src/components/Settings/SettingsAddressbook.vue Outdated
Show resolved Hide resolved src/components/Settings/SettingsAddressbook.vue Outdated
alert('change') // eslint-disable-line
this.$store.dispatch('toggleAddressbookEnabled', this.addressbook)
}
action: this.toggleAddressbookEnabled
},
{
icon: 'icon-delete',

This comment has been minimized.

@skjnldsv

skjnldsv Sep 4, 2018

Member

Remember that we do not want the user to delete her/his last addressbook 🤔 👍
We might require a small check there!

This comment has been minimized.

@sleepypioneer

sleepypioneer Sep 4, 2018

Member

cool can you give me a pointer to somewhere this check is done so I have a template to follow?

This comment has been minimized.

@skjnldsv

skjnldsv Sep 4, 2018

Member

I guess add a conditional check on the computed for the menu.

if (addressbooks.length > 1) {
    menu.push({itemObject})
}

There a re different check like that, for example, you cannot change the enable state of a readonly addressbook, nor rename it, stuff like that :)

This comment has been minimized.

@sleepypioneer

sleepypioneer Sep 5, 2018

Member

arh got you, good point not thought of this 😀

This comment has been minimized.

@sleepypioneer

sleepypioneer Sep 5, 2018

Member

but wait why wouldn't we let them delete the last one? @skjnldsv

This comment has been minimized.

@skjnldsv

skjnldsv Sep 5, 2018

Member

We could, but we need to be prepare for the contact to not find anything and adding a message saying "please create an addressbook before adding any contact" or somthing :)

This comment has been minimized.

@sleepypioneer

sleepypioneer Sep 5, 2018

Member

which solution do you prefer 😸 ?

This comment has been minimized.

@skjnldsv

skjnldsv Sep 5, 2018

Member

I guess it's easier to prevent the removal of the last one than adding checks everywhere to force the user to add a new one. :)

This comment has been minimized.

@sleepypioneer

sleepypioneer Sep 5, 2018

Member

cool 😎 thank you 👍

Show resolved Hide resolved src/components/Settings/SettingsAddressbook.vue
Show resolved Hide resolved src/components/Settings/SettingsAddressbook.vue
Show resolved Hide resolved src/components/core/popoverMenu/popoverItem.vue Outdated

skjnldsv and others added some commits Sep 4, 2018

Cleanup compiled file, css and prevent popup closing
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Automatic key and some fixes on the design of inputs
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Allow href + action in popover but action prevent link redirection + …
…adb.url fix

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Show resolved Hide resolved src/components/Settings/SettingsAddressbook.vue Outdated
Show resolved Hide resolved src/store/index.js Outdated

skjnldsv and others added some commits Sep 6, 2018

Key fallback
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Jessica Jessica
Merge branch 'vue-settings-addressbook-popovermenu' of github.com:nex…
…tcloud/contacts into vue-settings-addressbook-popovermenu

@sleepypioneer sleepypioneer merged commit c3291bc into vue Sep 7, 2018

Rails Girls Summer of Code 2018 automation moved this from 👩‍💻 In progress to 🎉 Done! Sep 7, 2018

@sleepypioneer sleepypioneer deleted the vue-settings-addressbook-popovermenu branch Sep 7, 2018

@nextcloud-bot nextcloud-bot referenced this pull request Sep 11, 2018

Open

Allow to set a date without a year #625

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment