Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextcloud 22 compatibility #764

Closed
ben16w opened this issue Jul 7, 2021 · 4 comments · Fixed by #778
Closed

Nextcloud 22 compatibility #764

ben16w opened this issue Jul 7, 2021 · 4 comments · Fixed by #778
Labels
enhancement New feature or request

Comments

@ben16w
Copy link

ben16w commented Jul 7, 2021

Hi, Nextcloud 22 was released today. Will Cookbook be updated to support it?

Many thanks to everyone who's worked on this project. I use it almost daily!

@ben16w ben16w added the enhancement New feature or request label Jul 7, 2021
@christianlupus
Copy link
Collaborator

It will be made available for NC 22. Currently, we have to settle #763/#762 before a new release can be published.

@ben16w
Copy link
Author

ben16w commented Jul 8, 2021

Ok thanks for the info @christianlupus

@ben16w ben16w closed this as completed Jul 8, 2021
@christianlupus christianlupus reopened this Jul 8, 2021
@MoralCode
Copy link
Contributor

after looking at the two issues mentioned, it seems as though both are resolved, nearly resolved, or only applicable to some usecases (like shared instances).

Is there a current summary of which users should and should not attempt to update the nextcloud cookbook app?

From my brief reading of the issues it seems like if you 1) do not share your instance with anyone and 2) back up your cookbook folder, delete the app, and install version 0.9.1 manually/fresh it should be safe to perform this upgrade, even though this version is not listed on the store due to the mentioned issues making it an upgrade unsuitable as a matter of general advice for all users.

Is this a correct analysis of the problem? do others who are more familiar with this issue agree that the described set of users are in the clear as far as upgrading?

@christianlupus
Copy link
Collaborator

If there are no further (yet hidden) problems in the new version, it seems pretty well explained. I am preparing a fix for all cases I can think of but yet the PostgreSQL code is missing/faulty and the automated tests cause trouble at the moment.

The way removing the app installing the 0.9.1 version from GitHub directly should (unless we missed another bug yet) work. You will lose the cached versions of your recipes so the first start of the app might take quite some time for each user using the app. If you had a really big cookbook folder, you might run into timeouts by your web server. You could test this by creating a new NC user and copying the recipes over. The parsing was not modified so when this test runs smoothly, you should not have trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants