Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add support for circles app [$15] #126
Basic group sharing is working now in my app :). I´m willing to implement it here once i finished the first version of my app.
@juliushaertl i noticed that nc does existence checking here https://github.com/nextcloud/server/blob/master/apps/files_sharing/lib/Controller/ShareAPIController.php#L319-L491 and also checks if e.g group sharing is allowed. Perhaps we should add that too when implementing circle sharing?
Yeah, you are right. With support for circles we need to use the displayname instead uf the id because the circles have a pretty cryptic one. After some research it works pretty well for me :) https://github.com/splitt3r/mindmaps/tree/master/lib/Db/Acl.php#L66-L87 & https://github.com/splitt3r/mindmaps/tree/master/lib/Controller/AclController.php#L104-L141