Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for circles app [$15] #126

Closed
Pisoko opened this issue May 8, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@Pisoko
Copy link

commented May 8, 2017

Deck is not compatible with circle-app.
It would be nice to share the decks with the circle-defined contacts.

Greets from germany
Pisoko

Bountysource


There is a $15 open bounty on this issue. Add to the bounty at Bountysource.

@juliushaertl juliushaertl added the bounty label Jun 8, 2017

@juliushaertl juliushaertl added this to the 0.3.0 milestone Jun 20, 2017

@juliushaertl juliushaertl changed the title Deck and Circle (nextcloud 12) Deck and Circle (nextcloud 12) [$15] Jul 2, 2017

@juliushaertl juliushaertl changed the title Deck and Circle (nextcloud 12) [$15] Add support for circles app [$15] Jul 2, 2017

@artemanufrij artemanufrij modified the milestones: 0.3.0, 0.2.1 Jul 4, 2017

@splitt3r

This comment has been minimized.

Copy link

commented Oct 28, 2017

The solution could also be used for the Polls app 👍.

@splitt3r

This comment has been minimized.

Copy link

commented Nov 27, 2017

Basic group sharing is working now in my app :). I´m willing to implement it here once i finished the first version of my app.

@juliushaertl i noticed that nc does existence checking here https://github.com/nextcloud/server/blob/master/apps/files_sharing/lib/Controller/ShareAPIController.php#L319-L491 and also checks if e.g group sharing is allowed. Perhaps we should add that too when implementing circle sharing?

@juliushaertl

This comment has been minimized.

Copy link
Member

commented Nov 27, 2017

Yes it would make sense to also respect that setting. It might be already respected when fetching the list of users/groups since we use a server API for that, but it should of course also be checked when the actual sharing happens.

@splitt3r

This comment has been minimized.

Copy link

commented Nov 27, 2017

Yeah, you are right. With support for circles we need to use the displayname instead uf the id because the circles have a pretty cryptic one. After some research it works pretty well for me :) https://github.com/splitt3r/mindmaps/tree/master/lib/Db/Acl.php#L66-L87 & https://github.com/splitt3r/mindmaps/tree/master/lib/Controller/AclController.php#L104-L141

@juliushaertl juliushaertl modified the milestones: 0.3.0, 0.4.0 Dec 16, 2017

@juliushaertl juliushaertl modified the milestones: 0.4.0, Backlog Jun 28, 2018

@juliushaertl juliushaertl removed this from the Backlog milestone Oct 25, 2018

@juliushaertl juliushaertl added this to the 🔧 Next minor 0.6 milestone Feb 27, 2019

@juliushaertl juliushaertl referenced this issue Mar 5, 2019

Merged

Share with circles #923

5 of 5 tasks complete
@juliushaertl

This comment has been minimized.

Copy link
Member

commented Mar 28, 2019

Implemented with #923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.