Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add validators to check values in services #4059

Merged
merged 2 commits into from Oct 31, 2022

Conversation

luka-nextcloud
Copy link
Contributor

Signed-off-by: Luka Trovic luka@nextcloud.com

  • Resolves: #
  • Target version: master

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@stefan-niedermann
Copy link
Member

Any breaking changes in here? I didn't see one at the first look, but just to make sure 😉

lib/Validators/BaseValidator.php Outdated Show resolved Hide resolved
lib/Validators/AssignmentServiceValidator.php Show resolved Hide resolved
lib/Service/StackService.php Outdated Show resolved Hide resolved
lib/Service/LabelService.php Outdated Show resolved Hide resolved
lib/Validators/BaseValidator.php Outdated Show resolved Hide resolved
lib/Validators/BaseValidator.php Outdated Show resolved Hide resolved
lib/Validators/BaseValidator.php Outdated Show resolved Hide resolved
lib/Validators/BaseValidator.php Outdated Show resolved Hide resolved
lib/Validators/BaseValidator.php Outdated Show resolved Hide resolved
lib/Validators/BaseValidator.php Outdated Show resolved Hide resolved
@juliushaertl
Copy link
Member

@luka-nextcloud Indentation seems off quite a bit in some places. Maybe double check your editor settings to use tab indentation. php-cs-fixer should however be able to auto fix those with composer run cs:fix

@luka-nextcloud
Copy link
Contributor Author

@juliushaertl Please check again.

@luka-nextcloud luka-nextcloud force-pushed the feature/improve-security-level branch 2 times, most recently from 64ccef1 to 4228cc0 Compare October 14, 2022 17:23
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl merged commit a231061 into master Oct 31, 2022
26 checks passed
@juliushaertl juliushaertl deleted the feature/improve-security-level branch October 31, 2022 11:59
@juliushaertl
Copy link
Member

/backport to stable25

@juliushaertl
Copy link
Member

/backport to stable24

@juliushaertl
Copy link
Member

/backport to stable23

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants