Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.5.1] client marks ignored files as sync conflict #566

Open
Germano0 opened this issue Aug 18, 2018 · 47 comments

Comments

@Germano0
Copy link

commented Aug 18, 2018

I installed 2.5.0 over a previous 2.3.3 version. With the old client version, the folders synchronization was okay, with 2.5.0 instead it is stuck on a specific folder (let's call it "LLL") marked with "there are unresolved conflicts, click for details". I click and I simply get a list of files being ignored because they are usually temp or backup files, like .foo.bar, foo.bar~, ~foo.bar.
So there are no conflicts, only files being ignored.

Note that as soon the "LLL" folder start the sync, I get the alert message and the sync stops

@camilasan camilasan self-assigned this Aug 19, 2018

@camilasan camilasan added this to To do in Desktop Client 2.5 Series via automation Aug 19, 2018

@zippytiff

This comment has been minimized.

Copy link

commented Oct 12, 2018

Hi,

I have just tried my 1st 2.5 build (Nextcloud-2.5.0.61459-daily-20181011)

I can see the Files ignored by Patterns, has been dramatically reduced, which is good.

However I also see this issue, except that despite hidden files being syncd is on, I get:

File is listed on the ignore list for ~$sampleexcel.xls (yes the file is closed)

Also im getting error on various files for Conflicts, where Server version downloaded, local copy renamed and not uploaded

finally .iTunes Preferences.plist thowing an error

In the end I just want everything to sync, unless either chosen by the server (which that feature was in this version eg settings controlled by the server !) or by me.

Me just seeing a Green tick as per 2.3.3

I will revert back to that version for now

Thanks ZT

@zippytiff

This comment has been minimized.

Copy link

commented Oct 15, 2018

Solution was to not use the client gui, but to edit the file in the new roaming (not local anymore) location

Guess this is a client bug....

ZT

@heidlma

This comment has been minimized.

Copy link

commented Oct 31, 2018

I am seeing the same issue. The 2.5 client gives me "unresolved conflicts", but when I click on the message ("Click for details"), nothing happens.

I am running on macOS HS, client version is 2.5.0rc1 (build 20181026)

After downgrade to 2.3.3 client, all seems to be ok again.

@augustseptember

This comment has been minimized.

Copy link

commented Nov 14, 2018

In the 2.5git (ubuntu18.04) i get the same "unresolved conflicts". If I click on it, it shows me a very long list of ignored files, which should not be ignored anymore due to the reduced ignore patterns.

@TP75

This comment has been minimized.

Copy link

commented Nov 15, 2018

Confirmed. The same issue with macOS 10.12 and NC Client Nextcloud-2.5.0.20181112.pkg i.e. Version 2.5.0daily (build 20181112) for all the users of our local NC 13.0.7 server.

One may consider the Nextcloud Client Manual section Conflicts to manually resolve the a.m. issue. However, I am unsure if the paragraph Uploading conflicts (experimental) might be useful for a workaround or would be misleading.

Please be aware there appears to be a more general documentation issue What is the current Client Manual? #839 One would expect the availability of a documentation for both the 2.3 and the 2.5 NC Client.

@Germano0 Germano0 changed the title [2.5.0b1] client marks ignored files as sync conflict [2.5.0] client marks ignored files as sync conflict Nov 15, 2018

@Germano0

This comment has been minimized.

Copy link
Author

commented Nov 15, 2018

I still experience the problem on 2.5.0 final.
I will not push nextcloud-client to Fedora / EPEL stable repository until this problem will be fixed

@wiserweb

This comment has been minimized.

Copy link

commented Nov 16, 2018

Confirming that the issue described by OP is still occurring.
It occurs on Linux as well.
Confirming that MacOS and Linux client with 2.3.3 do not exhibit this bug.
I suppose this will have to be a new test-case that will be added to QA so to ensure that this functionality is properly tested before shipping a release as production ready.

@rullzer

This comment has been minimized.

Copy link
Member

commented Nov 19, 2018

Does anybody have log files or steps to reproduce this?
I tried it locally and it seems just to work no mater what I put in the ignore pattern

@augustseptember

This comment has been minimized.

Copy link

commented Nov 19, 2018

Trying to sync a file with ~ at the end of the filename the client logs say:

...[_csync_merge_algorithm_visitor INSTRUCTION_IGNORE client file: path/to/file/file_with_tilde~ ... [csync_ftw <= Closing walk for with read_from_db 0 [csync_update Update detection for remote replica took 74.093 seconds walking 31725 files [csync_memstat_check Memory: 2486580K total size, 873896K resident, 30828K shared [OCC::SyncEngine::slotDiscoveryJobFinished #### Discovery end #################################################### 91355 ms ... [OCC::PropagateItemJob::scheduleSelfOrChild Starting INSTRUCTION_IGNORE propagation of "path/to/file/file_with_tilde~" by OCC::PropagateIgnoreJob(0x55ddcab01f60) [OCC::PropagateItemJob::done Could not complete propagation of "path/to/file/file_with_tilde~" by OCC::PropagateIgnoreJob(0x55ddcab01f60) with status 6 and error: "Die Datei ist in der Ignorierliste geführt." [OCC::ActivityWidget::slotItemCompleted Item "path/to/file/file_with_tilde~" retrieved resulted in "Die Datei ist in der Ignorierliste geführt." [OCC::ActivityWidget::slotItemCompleted Item "path/to/file/file_with_tilde~" retrieved resulted in error "Die Datei ist in der Ignorierliste geführt." [OCC::ActivityListModel::addErrorToActivityList Error successfully added to the notification list: "Die Datei ist in der Ignorierliste geführt."

But in the ignore list is no entry for files with ~
ignorelist

@leighss

This comment has been minimized.

Copy link

commented Nov 19, 2018

@augustseptember
My ignore files settings looked like that until I took @brianbgness advice from #851 and reset to defaults, then lots of other entries (including ~ones) appeared in the list

@augustseptember

This comment has been minimized.

Copy link

commented Nov 19, 2018

@leighss thanks for the advice but this doesn't change anything for me.

@rullzer

This comment has been minimized.

Copy link
Member

commented Nov 19, 2018

@augustseptember that is a different issue. But ~ files are ignored because they are temp files by definition.we probably can make that more clear

@leighss

This comment has been minimized.

Copy link

commented Nov 19, 2018

That also didn't change anything for me, but I thought it may have helped in diagnosing problem

@augustseptember

This comment has been minimized.

Copy link

commented Nov 19, 2018

@rullzer yes there could be some fixed entries in the ignore list, which can't be deleted from that list. You would at least be informed that some patterns (~) or files (like .htacess) are generally not synced.

But why is there still the warning about conflicts in the client?

@rullzer

This comment has been minimized.

Copy link
Member

commented Nov 19, 2018

Note that .htaccess is blocked server side.

I do not know why the warning is there. That is why I need steps to reproduce as it doesn't happen for me. No matter what I add to the sync list. Only if create conflicts in files that are synced I see them but that is to be exepcted.

@rullzer

This comment has been minimized.

Copy link
Member

commented Nov 19, 2018

Ah ok at least I'm a step further. It indeed looks like the system exclude list is always read. I'm not sure how this snuck back in. I'll prepare a PR to fix that at least.

@augustseptember

This comment has been minimized.

Copy link

commented Nov 19, 2018

hmm...
i just updated my nextcloud-client from 2.3.3 to 2.5 with your ppa for ubuntu 18.04. The yellow warnings was there from the beginning.

@leighss

This comment has been minimized.

Copy link

commented Nov 19, 2018

Hopefully I am not muddying the waters as I do not understand the technicalities, but...

@rullzer mentioning .htaccess jogged my memory...

I did notice that amongst the many yellow ! warning logs about ignored files there were two red X server error logs and when I followed them in the file manager they were .htaccess files in my synced content.

I have three locations (I'll call them A, B & C) that I sync.
One .htaccess files is in B, and the other in C.
However, A & C give me a yellow ! error overall, not a red X.

A has started to give me a green tick again (I am not sure why, perhaps after resetting defaults?) and has no error relating to an .htaccess file

rullzer added a commit that referenced this issue Nov 19, 2018
Do not read system exclude list if user exclude is present
For #566

Since we only showed the user exclude list (and some extra items) the
system exclude list was still used.

This copies over the system exclude list (if it isn't there).
If it fails we use the system one still.

However if you now remove items from your own list it will really be
gone.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer

This comment has been minimized.

Copy link
Member

commented Nov 19, 2018

I do not think this solves it but it should make hte list more clear: #860

@TrilceAC

This comment has been minimized.

Copy link

commented Nov 21, 2018

I'm having the same conflict issue described above. With the previous version on a Ubuntu 16.04 I had no issue. I've just update to 2.5.0git using the repository and now I have lots of "File is listed on the ignore list". In my case, I use Nextcloud to sync some python projects I'm working on. This is quite useful when changing from PC to laptop or going home. Sometimes the code is not in a state that I can commit, but I want to see and finish what I was working on on a different computer. To avoid silly or prejudicial syncs I added to the ignored files the following two patterns:

*.pyc
__pycache__/*

This has been working fine for me untill now. Since the update I see the yellow flag indicating that "There are unresolved conflicts. Click for details" When I click, all *.pyc files are mark as conflictive saying that "File is listed on the ignore list."

I hope I'm not doing something obviouly wrong and that this report helps to solve the issue.

@get2him

This comment has been minimized.

Copy link

commented Nov 21, 2018

This has been working fine for me untill now. Since the update I see the yellow flag indicating that "There are unresolved conflicts. Click for details" When I click, all *.pyc files are mark as conflictive saying that "File is listed on the ignore list."

I hope I'm not doing something obviouly wrong and that this report helps to solve the issue.

I had the same problem with win client 2.5.0.
I've checked the option to sync hidden files in the Advanced Options -> Ignored Files Editor.
The issue resolved.

@TrilceAC

This comment has been minimized.

Copy link

commented Nov 21, 2018

I had the same problem with win client 2.5.0.
I've checked the option to sync hidden files in the Advanced Options -> Ignored Files Editor.
The issue resolved.

I think you resolved the issue because you are now sync hidden files. I already had this option marked but the isssue is there.

As mentioned here, I have just clicked on "Restore Defaults" and the list of ignored patters has significantly increased. Before clicking OK I have added the two extra patterns I mentioned above and I have clicked OK. After clicking, Nextcloud has performed a full check for changes. While it was performing it, it was happy with the sync, but just when it ended, the yellow flag and the unresolved conflicts have come back because of the .pyc files.

@leighss

This comment has been minimized.

Copy link

commented Nov 21, 2018

@TrilceAC - exactly the same behaviour as happened with me
I had already:
Reset to defaults (list increased)
Selected sync hidden files

but still had the same behaviour

Then I took @mr-bolle's advice (from my forum post) and deleted all the _conflict files (I just searched for them using catfish).

This did not initially work, but a few more syncs latter I got the green ticks again :)
I also reset to defaults one more time after deleting the conflict files, but I don't know if this was part of the solution/ what triggered the green ticks once the _conflict files had been deleted.

The conflict files were from 09/09/2018, so they were already there and not giving this behaviour with client 2.3.3, this only started with 2.50

@rullzer

This comment has been minimized.

Copy link
Member

commented Nov 21, 2018

@leighss it makes sense it showsthere are unresolved conflicts if you still have conflict files.

Of course clicking on the message should show you which files.

I guess there might be an issue with conflict files and ignored file detection. I'll try to reproduce that.

@jamincollins

This comment has been minimized.

Copy link

commented Nov 21, 2018

I can confirm that 2.5 is reporting a file conflicts but the link only takes me to a list of ignored (hidden) files. Manually grepping the Nextcloud tree for _conflict did however find a file that I was then able to remove. This is a rather poor user experience as-is.

@augustseptember

This comment has been minimized.

Copy link

commented Nov 22, 2018

Thanks to @jamincollins I found one single "_conflict" file among all the ignored and hidden files. After deleting this "_conflict" file the green tick was there again.
So maybe this is not a real bug, but my list of ignored files was sooo big, that i simply didn't see the conflict file in the activity view.

Suggestion: let users sort or filter the activity-view by conflict or ignored files. Or simply put the conflict files on top, so you can instantly see the problem. (sorry for my bad english, i hope it was clear enough)

@TrilceAC

This comment has been minimized.

Copy link

commented Nov 22, 2018

@augustseptember @jamincollins this has helped me too. Thanks!

@rullzer

This comment has been minimized.

Copy link
Member

commented Nov 22, 2018

Right so conflict files and ignored files have the same icon and they are not ordered it seems.
I'll see what we can do there.

@leighss

This comment has been minimized.

Copy link

commented Nov 22, 2018

@rullzer in the hope that it may help, a couple of observations from my case:

  1. The (old) conflict files were ignored by 2.3.3, the warning was only flagged when upgrading to 2.5.0

  2. When I clicked on the link I was directed to a 'file ignored' error (I am pretty sure it was the most recent one in a long list), NOT to a conflict error. In fact there were no conflict errors (despite the fact that I did find a couple of '_conflict' files) only 'file ignored' warnings

@LukeLR

This comment has been minimized.

Copy link

commented Nov 27, 2018

Happens for me as well in 2.5.0, and is a bit annoying. I have disabled the "sync hidden files" checkmark, since I have a lot of backup and meta files in my local Nextcloud directory I don't want to sync. Also, there's symbolic links that can't be synced. It would be nice to have a possibility to dismiss these warnings, since otherwise my Nextcloud is yellow all the time and I can't see if it is properly synced or not.

@dszego

This comment has been minimized.

Copy link

commented Jan 16, 2019

Jan. 15 2019 - same as everything described above.

@Germano0 Germano0 changed the title [2.5.0] client marks ignored files as sync conflict [2.5.1] client marks ignored files as sync conflict Jan 16, 2019

@koroki

This comment has been minimized.

Copy link

commented Feb 4, 2019

Same here...

Arch Linux, x86_64 cleint 2.5.1.git

@Githopp192

This comment has been minimized.

Copy link

commented Mar 3, 2019

Me2, just did the Client (Windows 10) Upgrade to SyncAgent, 2.5.1final (build 20181204).
Now .. SyncStatus is not green, saying conflicts .. i did remove all files manually with names ".. conficts" .. but when clicking onto the message in the NC-Client Gui "there are conflicts" .. it Shows me a lot of files, which are ignored .. but i do not see any conflict .. also, it would be very helpfull to search into this Gui context, to sort all the stuff ..

@Githopp192

This comment has been minimized.

Copy link

commented Mar 3, 2019

Now, after Rebooting all the Stuff (Windows 10), the NC SyncAgent 2.5.1 got the green flag again.

@Biopticon

This comment has been minimized.

Copy link

commented Apr 13, 2019

I have version 2.5.1 of the client, and the NC version is 14.0.6. My OS is Win 7 pro. NC is running on Ubuntu 18.04.
I removed all the conflicts it was reported by the client. All the entries in the log file are ignored files. If I click on the tab to go to the log to the conflict, there is none. I tried both Sync hidden files on or off. I reset the default ignore files option. But still, three folders on my drive marked after the scan are yellow.

Also, I get a warning that OpenOffice app has a new version but I do not have this app!

@bunjes

This comment has been minimized.

Copy link

commented May 28, 2019

Still present in MacOS Client 2.5.2git (Build 20190319)

@David-Lor

This comment has been minimized.

Copy link

commented Jun 6, 2019

Still present under Ubuntu (2.5.2git)

@paulsommer

This comment has been minimized.

Copy link

commented Jun 18, 2019

Same here. The activity list is flooded with yellow exclamation marks.rendering it useless for finding real conflicts.

@ppochon

This comment has been minimized.

Copy link

commented Jul 7, 2019

Same here on ubuntu 16.04, "le fichier ou dossier a été ignoré car il est masqué". I lose the amount of data transfered information because of the information displayed. Make difficult to see real problems.

@cloo

This comment has been minimized.

Copy link

commented Aug 2, 2019

Same here on Windows 10 client / Ubuntu 18.04 server / Nextcloud 16.0.3

@Derridaralalala

This comment has been minimized.

Copy link

commented Sep 13, 2019

This is still an issue in MAC OS clients from 2.5.2 up to 2.6 RC1. Crazy.

@keunes

This comment has been minimized.

Copy link

commented Sep 16, 2019

I was going to create a new issue but GitHub suggested me this one instead. I had the impression I already had similar issues under 2.3, but I just upgraded to 2.5.3daily-Win64 (build 20190725) on Windows 10 and I (still) have the issue for sure. Indeed the most annoying thing is to be wrongly suggested that things are off while all actually is fine, as indicated by @LukeLR.

@keunes

This comment has been minimized.

Copy link

commented Sep 16, 2019

Also experiencing this issue?

Please consider giving a thumbs-up to the original post. It can help indicate this issue as one that's affecting many users.

@paulsommer

This comment has been minimized.

Copy link

commented Sep 16, 2019

It's hard to believe that such a simple issue is not fixed after one year. Seems as if the developer is not interested and someone has to fork the whole thing to fix that annoying error.

@Derridaralalala

This comment has been minimized.

Copy link

commented Sep 22, 2019

@paulsommer agree. the only working version in this matter seems to be Nextcloud-2.3.3.84. Even Version 2.6.0rc1 does not fix the issue(s). (@camilasan)

@LukeLR

This comment has been minimized.

Copy link

commented Sep 22, 2019

@camilasan

This comment has been minimized.

Copy link
Member

commented Sep 23, 2019

I can't reproduce the problem mentioned by @Germano0. I see that in my file manager a conflict file has the same icon as an ignored file but that is not the case in the client main window. Would you - all affected by the problem - mind sharing some screenshots?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
You can’t perform that action at this time.