Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix macOS GUI (Qt 5.12) #1651

Open
wants to merge 3 commits into
base: master
from

Conversation

@misch7
Copy link
Member

misch7 commented Dec 1, 2019

Step 1: Remove submodule qtmacgoodies and the MacSettingsDialog class

Reverts back to the SettingsDialog class because of bugs and glitches with more recent Qt versions (Qt 5.12) and with the macOS Dark Mode.

See upstream: owncloud/client#7492

This hopefully fixes issue #1501 and some crashes.

GUI on macOS 10.14 (Mojave):
mac-gui

GUI on macOS 10.13 (High Sierra):
mac-gui03

@jancborchardt This also removes the height auto-resize on switching tabs ;-)
cc @camilasan

Test build: I created a special daily build, including this PRs code (macOS 10.12+):
https://download.nextcloud.com/desktop/daily/Mac/Installer/Nextcloud-qt5.12.5-2.7.0.20191201daily.pkg

Next steps:

  • Fixing DPI / Font issues
  • Dark Mode: changing colors of links and other GUI elements

Targeted issues:

Reverts back to the SettingsDialog class because of bugs and glitches with
more recent Qt versions (Qt 5.12) and with the macOS Dark Mode.

See upstream: owncloud/client#7492

Signed-off-by: Michael Schuster <michael@schuster.ms>
@jancborchardt

This comment has been minimized.

Copy link
Member

jancborchardt commented Dec 1, 2019

@jancborchardt This also removes the height auto-resize on switching tabs ;-)

Heh, seems good! 👍 :)

Signed-off-by: Michael Schuster <michael@schuster.ms>
@misch7

This comment has been minimized.

Copy link
Member Author

misch7 commented Dec 1, 2019

The low contrast is also a problem with the Dark Mode on macOS.

For reference please see:
- Commit: owncloud/client@413ef5e
- Issue: owncloud/client#7512

Signed-off-by: Michael Schuster <michael@schuster.ms>
@misch7 misch7 mentioned this pull request Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.