Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run legacy uninstall exe in a secure way #3497

Merged
merged 1 commit into from Jun 30, 2021

Conversation

allexzander
Copy link
Collaborator

@allexzander allexzander commented Jun 29, 2021

Signed-off-by: allexzander blackslayer4@gmail.com

UninstallString Registry property is created by NSIS installer. We must query it and then run the Uninstall.exe file that is contained within this property, or, do nothing if it is empty.

@allexzander allexzander force-pushed the bugfix/run-legacy-uninstall-in-a-secure-way branch from df74404 to 16f31cb Compare June 30, 2021 06:33
@allexzander
Copy link
Collaborator Author

/rebase

@github-actions github-actions bot force-pushed the bugfix/run-legacy-uninstall-in-a-secure-way branch from 2ff792c to e801dda Compare June 30, 2021 11:21
@mgallien
Copy link
Collaborator

/rebase

Signed-off-by: allexzander <blackslayer4@gmail.com>
@github-actions github-actions bot force-pushed the bugfix/run-legacy-uninstall-in-a-secure-way branch from e801dda to 860514f Compare June 30, 2021 11:58
@nextcloud-desktop-bot
Copy link
Collaborator

AppImage file: Nextcloud-PR-3497-860514f01bcd3ef02b09e0e36e423d45a7dcfc93-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 80267ad into master Jun 30, 2021
3 checks passed
@mgallien mgallien deleted the bugfix/run-legacy-uninstall-in-a-secure-way branch June 30, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants