Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macOS Info.plist #4755

Merged
merged 1 commit into from Jul 21, 2022
Merged

Update macOS Info.plist #4755

merged 1 commit into from Jul 21, 2022

Conversation

claucambra
Copy link
Collaborator

This should prevent running the client on versions of macOS we no longer support

Fixes #4722

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #4755 (1056bc5) into master (db90f5b) will decrease coverage by 0.13%.
The diff coverage is n/a.

❗ Current head 1056bc5 differs from pull request most recent head 032774e. Consider uploading reports for the commit 032774e to get more accurate results

@@            Coverage Diff             @@
##           master    #4755      +/-   ##
==========================================
- Coverage   56.56%   56.42%   -0.14%     
==========================================
  Files         138      138              
  Lines       17069    17070       +1     
==========================================
- Hits         9655     9632      -23     
- Misses       7414     7438      +24     
Impacted Files Coverage Δ
src/libsync/vfs/cfapi/hydrationjob.cpp 52.68% <0.00%> (-3.77%) ⬇️
src/libsync/vfs/cfapi/vfs_cfapi.cpp 83.84% <0.00%> (-2.63%) ⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 75.42% <0.00%> (-1.93%) ⬇️
src/libsync/syncengine.cpp 85.19% <0.00%> (-0.55%) ⬇️
src/libsync/owncloudpropagator.cpp 86.02% <0.00%> (+0.02%) ⬆️

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@claucambra claucambra force-pushed the bugfix/update-mac-info-plist branch from 1056bc5 to 032774e Compare July 21, 2022 13:08
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4755-032774e280c8ecc4d0ec32e2afdf1f742e0e07d1-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra claucambra merged commit 89fbadd into master Jul 21, 2022
@claucambra claucambra deleted the bugfix/update-mac-info-plist branch July 21, 2022 13:17
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra
Copy link
Collaborator Author

/backport to stable-3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS client: add info about minimum supported OS version
4 participants