Ensure that the file being processed has had its etag properly sanitised, log etag more

[claucambra]

Might address nextcloud/server#33785

@tobiasKaminsky

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

[claucambra]

/backport to stable-3.6

[tobiasKaminsky]

Thanks, I am testing it right now

[tobiasKaminsky]

This seems to be way better, but now "only" root one folder's etag keeps changing.
I can see also via web ui that modification date is always "a few seconds ago", while files/folders inside this folder have "13 days ago".
Files/folders next to the problematic folder, which are also synced, do not have a flipping eTag…

[tobiasKaminsky]

Hm. This seems to be unrelated to client, as it happens also in this case:

• note down etag: 123
• stop client
• refresh parent folder (where problematic folder is in) -> no change
• open folder via web
• see changing eTag

--> so it is enough to enter this folder to have a flipping etag

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-4940-0a2186f8d9bc1d513669eb00b0a8a6af50caec4a-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

8.3% Coverage
0.0% Duplication

[codecov]

Codecov Report

Merging #4940 (0a2186f) into master (c4b6eae) will increase coverage by 0.00%.
The diff coverage is 92.85%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4940   +/-   ##
=======================================
  Coverage   57.20%   57.20%           
=======================================
  Files         138      138           
  Lines       17138    17155   +17     
=======================================
+ Hits         9803     9813   +10     
- Misses       7335     7342    +7     

Impacted Files	Coverage Δ
src/libsync/discovery.cpp	84.32% <92.85%> (-0.24%)	⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp	74.20% <0.00%> (-0.46%)	⬇️
src/libsync/propagatedownload.cpp	65.03% <0.00%> (ø)