Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of plain text-enforcing qml labels #5233

Merged
merged 4 commits into from Dec 5, 2022

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Dec 2, 2022

This PR:

  • Replaces all use of Label and Text components in our QML code for a new EnforcedPlainTextLabel
  • Adds a basic check in our CI for the use of Label components (of which there should only be one, in EnforcedPlainTextLabel)

@claucambra claucambra self-assigned this Dec 2, 2022
@claucambra claucambra force-pushed the bugfix/enforce-plain-text-qml-labels branch 8 times, most recently from e204309 to 5a32fe9 Compare December 2, 2022 16:04
@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

… use this

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@allexzander allexzander force-pushed the bugfix/enforce-plain-text-qml-labels branch from 5a32fe9 to 2e37682 Compare December 5, 2022 14:21
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra merged commit 98e6ab2 into master Dec 5, 2022
6 of 8 checks passed
@claucambra claucambra deleted the bugfix/enforce-plain-text-qml-labels branch December 5, 2022 15:18
@claucambra
Copy link
Collaborator Author

/backport to stable-3.6

@backportbot-nextcloud
Copy link

The backport to stable-3.6 failed. Please do this backport manually.

@claucambra
Copy link
Collaborator Author

/backport to stable-3.6

@sonarcloud
Copy link

sonarcloud bot commented Dec 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link
Collaborator

AppImage file: nextcloud-PR-5233-19afb905c0bcd0c055552059d24e75d0d88dd745-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@backportbot-nextcloud
Copy link

The backport to stable-3.6 failed. Please do this backport manually.

@claucambra
Copy link
Collaborator Author

/backport to stable-3.6

@backportbot-nextcloud
Copy link

The backport to stable-3.6 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants