Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share dialog alignment #847

Merged
merged 16 commits into from Nov 19, 2018

Conversation

Projects
None yet
3 participants
@jpnurmi
Copy link
Member

commented Nov 17, 2018

Fixes #817.

jpnurmi added some commits Nov 15, 2018

ElidedLabel: add default constructor
Makes it possible to promote QLabel to an ElidedLabel in Qt Designer.
ShareUserLine: fix eliding
The widget doesn't have its final size at construction time, so the
width for eliding is not yet known. Let ElidedLabel do the job.
ShareDialog: align the left margin
All other margins are 10px.
ShareUserGroupWidget: sync the share confirm button size with others
This keeps also the total width of the share dialog constant.
Cleanup shareusergroupwidget.ui
Remove hard-coded fixed sizes, size constraints, and other unnecessary
property assignments. This works with any dialog width, meaning that
the width can be defined in one place higher up in the widget hierachy.
ShareLinkWidget: redo the layout
NOTE: The progress indicator is temporarily moved one line up to avoid
inserting it on its own line, which would cause the content pushed down
and the dialog size jump back and forth.
ShareDialog: increase the width
To match the old width it had before the alignment work.
@jpnurmi

This comment has been minimized.

Copy link
Member Author

commented Nov 17, 2018

Before After
share-dialog-before share-dialog-after

@jpnurmi jpnurmi requested review from camilasan, rullzer and juliushaertl Nov 17, 2018

@jpnurmi

This comment has been minimized.

Copy link
Member Author

commented Nov 17, 2018

I tried to avoid doing any bigger layout changes and keep things more or less the same. Personally, I would prefer to have that progress indicator somewhere else. :) I just put it on the same line with existing widgets for now, so it won't make the dialog size jump back and forth.

@rullzer rullzer requested a review from jancborchardt Nov 19, 2018

@rullzer rullzer merged commit 44b5e07 into nextcloud:master Nov 19, 2018

1 of 2 checks passed

continuous-integration/drone/pr the build failed
Details
fixupbot No fixup commits found. The commit history is clean
Details
@jancborchardt

This comment has been minimized.

Copy link
Member

commented Nov 22, 2018

Good stuff @jpnurmi! :) I’m working on Nextcloud design and @camilasan told me you are a Qt interface pro, so I’m super happy you’re here!

Will you by any chance be at the Contributor Week in Stuttgart next week? Otherwise we sould maybe have a chat at some point about the general direction of the design and also for me to understand what’s possible with Qt and what not really. (For example an improved tray menu design specified at #877)

@jpnurmi jpnurmi deleted the jpnurmi:share-dialog-take-2 branch Nov 22, 2018

@jpnurmi

This comment has been minimized.

Copy link
Member Author

commented Nov 22, 2018

Thanks! :) I won't be able to join the Contributor Week, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.