Bail early on illegal upgrade, fixes #1129 - #1304
Closed
jeppetrost wants to merge 1 commit into
Closed
jeppetrost wants to merge 1 commit into
jeppetrost wants to merge 1 commit into
Conversation
Added a helper function to check whether the upgrade is doable: returns true if major version (installed) + 1 is -lt major version (image). This lets you upgrade from eg. 10.X.Y -> 10.X+1.Z and 10.X.Y -> 11.A.B, but not 10.X.Y -> 12.A.B. If it detects this, the script will notify and bail immediately.
jeppetrost
changed the title
Contributor
|
Sad that this was not merged! It would have saved me quite some trouble. I have opened a new version of this PR here: #2018. |
This was referenced Jun 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a helper function to check whether the upgrade is doable: returns true if major version (installed) + 1 is -lt major version (image).
This lets you upgrade from eg. 10.X.Y -> 10.X+1.Z and 10.X.Y -> 11.A.B, but not 10.X.Y -> 12.A.B.
If it detects this, the script will notify and bail immediately.
Fixes #1129