fix(a11y): use <button> with aria-expanded for the version toggle#14835
Merged
Conversation
The version selector used a <span> as an interactive toggle, which has no native keyboard role or state indication (WCAG 4.1.2 / BITV 9.4.1.2). Screen readers could not announce whether the panel was expanded or collapsed. Changes across all three manual version templates: - Replace the <span> with a <button type="button"> so the element has native keyboard focus, click-on-Enter, and an implicit role. - Add aria-expanded="false" (updated to "true" on click via a small inline script that mirrors the RTD theme toggle). - Add aria-controls pointing to the versioned dropdown container. - Mark decorative caret icons with aria-hidden="true". Add CSS to reset default <button> styles so the visual appearance is unchanged. Fixes #9747 Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
github-actions
Bot
added
manual: admin
manual: developer
manual: user
3. to review
labels
Contributor
📖 Documentation PreviewNo RST documentation pages changed in this PR. Last updated: Tue, 12 May 2026 20:19:21 GMT |
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
susnux
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
Explanations
The version selector used a
<span>as an interactive control. Spans have no implicit ARIA role, no native keyboard focus semantics, and cannot carry anaria-expandedstate — failing WCAG 4.1.2 / BITV 9.4.1.2.Changes in all three manual version templates (
user_manual,developer_manual,admin_manual):<span class="rst-current-version">replaced with<button type="button">. The RTD theme JS uses[data-toggle]attribute selectors, so the element type change does not break the toggle.aria-expanded="false"added to the button; a small inline script mirrors the RTD toggle-class event to keep the attribute in sync.aria-controlslinks the button to its dropdown panel.<span>icons getaria-hidden="true".custom.cssso the button looks identical to the previous span.cc @nextcloud/a11y
✅ Checklist
codespellor similar and addressed any spelling issues