Enable browser cache for thumbnails

[stefaang]

As suggested in nextcloud/docker#848

[stefaang]

I've been reading into cache control a bit.. I guess private is more appropriate here so prevent privacy leaks. I'll make the change when I've got some feedback here.

[rullzer]

Which thumbnails do you mean here?
Because there should already be caching headers set on the previews you get back. If not then that is a bug.

[stefaang]

With browser cache - page reload = 1.3s

Without browser cache - page reload = 9s

As said, only applies to instances running on low-end hardware.

To be completely honest: this is actually a lighttpd server, not nginx.
But it demonstrates the benefit of adding a bit of browser caching. My main intension is to open up the discussion and provide a guideline for home users.
I wouldn't actually use this on decent server hardware.

[stefaang]

Ideally, the file browser uses browser cached icons when available on load, then updates them once any non-304 GETs come in.

[skjnldsv]

If it's optional, it should commented :)

[rullzer]

Ideally, the file browser uses browser cached icons when available on load, then updates them once any non-304 GETs come in.

Again, which request. Because the 304 on the previews should only happen after a day. Else something else if fishy.

So which requests (url please) are you trying to speed up here.
Because on all 4 setups I have access to icons are properly cached.

[stefaang]

So which requests (url please) are you trying to speed up here.

The preview urls.

Ah... I've changed my setup from lighttpd to nginx and it seems to resolve the problems.
No more need for this MR.

FYI, I'm working on an Entware (openwrt based) setup and there was only a guide for a lighttpd based installation that worked more or less out of the box. Unfortunately performance was lacking.

Thanks anyway for your time.