New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable browser cache for thumbnails #1609
Conversation
I've been reading into cache control a bit.. I guess private is more appropriate here so prevent privacy leaks. I'll make the change when I've got some feedback here. |
Which thumbnails do you mean here? |
Ideally, the file browser uses browser cached icons when available on load, then updates them once any non-304 GETs come in. |
# Optional: enable browser caching for thumbnails | ||
# Makes page loads really snappy for low power servers | ||
# but potentially slightly outdated | ||
add_header Cache-Control "public, max-age=86400"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's optional, it should commented :)
Again, which request. Because the 304 on the previews should only happen after a day. Else something else if fishy. So which requests (url please) are you trying to speed up here. |
The preview urls. Ah... I've changed my setup from lighttpd to nginx and it seems to resolve the problems. FYI, I'm working on an Entware (openwrt based) setup and there was only a guide for a lighttpd based installation that worked more or less out of the box. Unfortunately performance was lacking. Thanks anyway for your time. |
As suggested in nextcloud/docker#848