New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds template to urls #66

Merged
merged 2 commits into from Nov 21, 2017

Conversation

Projects
None yet
3 participants
@pierreozoux
Member

pierreozoux commented Nov 19, 2017

closes #64

@@ -79,6 +91,10 @@ public function get() {
$site['icon'] = $this->url->linkToRouteAbsolute('external.icon.showIcon', ['icon' => 'external.svg']);
}
$site['url'] = str_replace('{email}', $email, $site['url']);

This comment has been minimized.

@nickvergessen

nickvergessen Nov 20, 2017

Member

You can combine those 3 calls to one:

$site['url'] = str_replace(['{email}', '{uid}', '{displayname}'], [$email, $uid, $displayname], $site['url']);

@nickvergessen nickvergessen self-requested a review Nov 20, 2017

@nickvergessen nickvergessen added this to the Nextcloud 13 milestone Nov 20, 2017

@pierreozoux

This comment has been minimized.

Member

pierreozoux commented Nov 21, 2017

@nickvergessen Thanks for the feedback, I corrected!

Add some type hinting
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen

Fixed some theory issues myself

@nickvergessen nickvergessen merged commit bd0ccde into master Nov 21, 2017

@nickvergessen nickvergessen deleted the template_in_links branch Nov 21, 2017

@pierreozoux

This comment has been minimized.

Member

pierreozoux commented Nov 21, 2017

Thanks a lot! I'm really excited!

@pierreozoux

This comment has been minimized.

Member

pierreozoux commented Dec 8, 2017

Could we make a release with that? Thanks!

@nickvergessen

This comment has been minimized.

Member

nickvergessen commented Jan 10, 2018

https://apps.nextcloud.com/apps/external/releases?platform=13#13

Sorry I was on vacation...

But this will only be available in the upcoming 13 release

@pierreozoux

This comment has been minimized.

Member

pierreozoux commented Jan 10, 2018

@nickvergessen no problems! thanks!

@dachinat

This comment has been minimized.

dachinat commented Feb 1, 2018

Thanks for this feature. We have upgraded to 13.0.0 RC4, I have browsed apps/external/ directory and saw these changes, but I'm getting <iframe id="ifm" src="https://lvh.me:3000/user/login?l=en&amp;uid={uid}&amp;email={email}&amp;displayname={displayname}"></iframe> So, should this be working on 13.0.0 RC?

I have tried curl -H "OCS-APIRequest: true" https://user:pwd@localhost/ocs/v2.php/apps/external/api/v1 and it works. I thought we could have it for iframe as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment