New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded CSS rule for IE 11 #100

Merged
merged 1 commit into from Oct 1, 2018

Conversation

Projects
None yet
4 participants
@danxuliu
Copy link
Member

danxuliu commented Sep 26, 2018

This also happens to fix the PDF viewer in public share pages in IE 11 with current master and stable14 branches of server. Due to what looks like a typo the CSS rules of the server the width of app-content is forced to the width of the navigation bar; this width is ignored when content (its parent element) uses a flex display, but honoured when content uses a block display, so removing the rule (that overrode the default flex display for content) makes the app-content to fill the width of content instead of limiting it to the width of the navigation bar.

In any case this is just a coincidence and the server will be probably fixed before the next release anyway.

Remove unneeded CSS rule for IE 11
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

@MorrisJobke MorrisJobke merged commit 48a4771 into master Oct 1, 2018

4 checks passed

Scrutinizer No new issues
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MorrisJobke MorrisJobke deleted the remove-unneeded-css-rule-for-ie-11 branch Oct 1, 2018

@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Oct 1, 2018

Backport is in #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment