Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable14] Hide footer in public share page #103

Merged
merged 1 commit into from Oct 3, 2018

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Oct 3, 2018

Backport of #99

The footer in the public share page is hidden by adding the "hidden" CSS
class to the footer. However, the CSS rules for the footer defined in
the server are more specific than the general rule for ".hidden"
elements, which caused the footer to be shown even if marked as
".hidden". Now a more specific rule was added to override the ones from
the server and ensure that the footer is hidden.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@MorrisJobke
Copy link
Member Author

@MorrisJobke MorrisJobke commented Oct 3, 2018

Tested and works 👍

Copy link
Member

@ChristophWurst ChristophWurst left a comment

👍 🐘

@MorrisJobke
Copy link
Member Author

@MorrisJobke MorrisJobke commented Oct 3, 2018

CSS only -> merge

@MorrisJobke MorrisJobke merged commit db1f275 into stable14 Oct 3, 2018
0 of 3 checks passed
0 of 3 checks passed
continuous-integration/drone/pr this build is pending
Details
continuous-integration/drone/push this build is pending
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@MorrisJobke MorrisJobke deleted the backport/99/public-page-fix branch Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants