New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix embedded viewer with new server layout on IE 11 #95

Merged
merged 1 commit into from Sep 26, 2018

Conversation

Projects
None yet
2 participants
@danxuliu
Copy link
Member

danxuliu commented Sep 10, 2018

The embedded PDF viewer is shown in an iframe in front of the of the Files app by using absolute positioning. Since Nextcloud 14 the parent element of the iframe uses a flex layout, and the previous sibling of the iframe, the app-content element, is shown with flex-basis: 100vw.

In IE 11 the scenario above causes the iframe to be shown to the right of app-content instead of in front of it; it is necessary to explicitly set left: 0 to force the iframe to be aligned to the left of its positioning context (which in this case is its parent element) and thus in front of app-content.

@nextcloud/designers

Fix embedded viewer with new server layout on IE 11
The embedded PDF viewer is shown in an iframe in front of the of the
Files app by using absolute positioning. Since Nextcloud 14 the parent
element of the iframe uses a flex layout, and the previous sibling of
the iframe, the "app-content" element, is shown with
"flex-basis: 100vw".

In IE 11 the scenario above causes the iframe to be shown to the right
of "app-content" instead of in front of it; it is necessary to
explicitly set "left: 0" to force the iframe to be aligned to the left
of its positioning context (which in this case is its parent element)
and thus in front of "app-content".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

@danxuliu danxuliu merged commit cf0f8ef into master Sep 26, 2018

4 checks passed

Scrutinizer No new issues
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danxuliu danxuliu deleted the fix-embedded-viewer-with-new-server-layout-on-ie-11 branch Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment