Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code blocks in markdown rendering #120

Merged
merged 3 commits into from Oct 23, 2018

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Oct 16, 2018

Before:

bildschirmfoto 2018-10-16 um 14 04 45

After:

bildschirmfoto 2018-10-16 um 14 04 24

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Copy link
Member

@rullzer rullzer left a comment

I like it!

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Copy link
Member Author

@MorrisJobke MorrisJobke commented Oct 16, 2018

I also added some margin bottom to the details sections:

Before:
bildschirmfoto 2018-10-16 um 14 12 56

After:

bildschirmfoto 2018-10-16 um 14 12 20

@@ -77,6 +77,9 @@
background-color: rgb(242, 242, 242);
border-radius: 3px;
padding: 0px 2px 2px 2px;

This comment has been minimized.

@juliushaertl

juliushaertl Oct 16, 2018
Member

Some padding on the left (maybe a bit more in general) would be good I think. Besides that 👍

This comment has been minimized.

@MorrisJobke

MorrisJobke Oct 16, 2018
Author Member

bildschirmfoto 2018-10-16 um 14 36 15

Done

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke merged commit 97f01c3 into master Oct 23, 2018
4 checks passed
4 checks passed
Scrutinizer No new issues
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MorrisJobke MorrisJobke deleted the bugfix/noid/properly-show-markdown-code branch Oct 23, 2018
@MorrisJobke
Copy link
Member Author

@MorrisJobke MorrisJobke commented Oct 23, 2018

Backport in #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants