New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Fix ACE module files failing to load #83

Merged
merged 1 commit into from Feb 9, 2018

Conversation

Projects
None yet
3 participants
@danxuliu
Member

danxuliu commented Feb 8, 2018

Backport of #82

Fix ACE module files failing to load
When the ACE editor is initialized, by default the base path used to
load module files is set to the directory of the "ace.js" file. Since
the JavaScript files were merged "ace.js" is no longer added to the page
as a single script file, so the base path was no longer set, and thus
the module files failed to load. Now the right base path is explicitly
set in the editor configuration.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

@danxuliu danxuliu added this to the Nextcloud 13.0.1 milestone Feb 8, 2018

@danxuliu danxuliu requested review from rullzer and icewind1991 Feb 8, 2018

@rullzer rullzer merged commit 65e8158 into stable13 Feb 9, 2018

3 checks passed

continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rullzer rullzer deleted the stable13-82-fix-ace-module-files-failing-to-load branch Feb 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment