Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore query arguments in single video share for stable15 (Fix #121) #122

Conversation

@MathieuDebit
Copy link

@MathieuDebit MathieuDebit commented Mar 17, 2019

Same fix as commit 4da10ee but for stable15. See #121.

I'm not sure to know how to contribute here so tell me if it's good 馃檹

Same fix as commit 4da10ee for stable15

Signed-off-by: Mathieu D茅bit <mathieu+github@debit.email>
@MathieuDebit MathieuDebit force-pushed the stable15-fix-ignore-query-arguments-video branch from b214f85 to 27dfbd3 Mar 17, 2019
Copy link
Member

@juliushaertl juliushaertl left a comment

Thanks for your contribution. Looks good except for the version bump.

Loading

appinfo/info.xml Outdated
@@ -10,7 +10,7 @@

Skin: https://github.com/cabin/videojs-sublime-skin
</description>
<version>1.4.0</version>
<version>1.4.1</version>
Copy link
Member

@juliushaertl juliushaertl Mar 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to bump the version in this PR.

Loading

Signed-off-by: Mathieu D茅bit <mathieu+github@debit.email>
@MathieuDebit MathieuDebit force-pushed the stable15-fix-ignore-query-arguments-video branch from 05a2490 to b473b04 Mar 20, 2019
@MathieuDebit
Copy link
Author

@MathieuDebit MathieuDebit commented Mar 21, 2019

@juliushaertl I updated the PR 馃憣

Loading

@juliushaertl juliushaertl merged commit c87bbd8 into nextcloud:stable15 Mar 21, 2019
3 checks passed
Loading
@rullzer rullzer mentioned this pull request Mar 29, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants