New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Assume Document Root #78

Merged
merged 1 commit into from Oct 31, 2018

Conversation

Projects
None yet
3 participants
@uwecmyersjj
Copy link
Contributor

uwecmyersjj commented Aug 13, 2018

If NC is installed in a subdirectory, the link doesn't work properly.

@MorrisJobke MorrisJobke requested a review from juliushaertl Aug 20, 2018

@@ -39,6 +39,6 @@
<li><?php p($l->t('Many others like a music player, a password manager, a kanban app, a download manager or a markdown editor')); ?></li>

</ul>
<p class="details-link"><a href="/index.php/settings/apps" target="_blank"><?php p($l->t('Browse the app store')); ?></a></p>
<p class="details-link"><a href="index.php/settings/apps" target="_blank"><?php p($l->t('Browse the app store')); ?></a></p>

This comment has been minimized.

@juliushaertl

This comment has been minimized.

@J0WI

J0WI Oct 27, 2018

Contributor

Since there was no response so far I added a commit to the branch.

@juliushaertl

This comment has been minimized.

Copy link
Member

juliushaertl commented Oct 30, 2018

@J0WI Thanks for fixing, can you make sure to add a sign off message to your commit and maybe squash them into one? Otherwise, fine to merge by me. 👍

Do not assume document root
If NC is installed in a subdirectory, the link doesn't work properly.

Co-authored-by: Joshua Myers <github@myersjj.com>
Signed-off-by: J0WI <J0WI@users.noreply.github.com>

@J0WI J0WI force-pushed the uwecmyersjj:patch-1 branch from 42bb5b6 to 7594c98 Oct 30, 2018

@J0WI

This comment has been minimized.

Copy link
Contributor

J0WI commented Oct 30, 2018

Squashed and signed

@J0WI J0WI self-assigned this Oct 30, 2018

@juliushaertl juliushaertl merged commit daae27d into nextcloud:master Oct 31, 2018

1 check passed

continuous-integration/drone/pr the build was successful
Details

@uwecmyersjj uwecmyersjj deleted the uwecmyersjj:patch-1 branch Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment