Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve and unify Markdown output style #1575

Merged
merged 1 commit into from Apr 2, 2023
Merged

Improve and unify Markdown output style #1575

merged 1 commit into from Apr 2, 2023

Conversation

susnux
Copy link
Collaborator

@susnux susnux commented Mar 20, 2023

Improve the output style the get a consistent styling across apps (e.g. this style is used by text and collectives.

before after
No indention, no styling basic styling

@susnux susnux added design Related to the design 3. to review Waiting for reviews labels Mar 20, 2023
jancborchardt
jancborchardt approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiice! @susnux great stuff as usual! ✨

Requesting review from our Markdown/Text experts @max-nextcloud and @mejo- as well. :)

jotoeri
jotoeri approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@jotoeri jotoeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

mejo-
mejo- approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @susnux. I don't have much insights into the Forms app, but screenshots and code changes look sensible and like a great improvement.

@jotoeri jotoeri added the enhancement New feature or request label Apr 2, 2023
@jotoeri
Copy link
Member

jotoeri commented Apr 2, 2023

/rebase

@susnux @jotoeri
design: Unify Markdown output style with text and collectives apps
49acd8d 
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
@jotoeri jotoeri merged commit 3297a14 into main Apr 2, 2023
20 checks passed
@jotoeri jotoeri deleted the design/unify-markdown-output branch April 2, 2023 15:02
@jotoeri jotoeri added this to the 3.3 milestone May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@mejo- mejo- mejo- approved these changes

@Chartman123 Chartman123 Chartman123 approved these changes

@jotoeri jotoeri jotoeri approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

Assignees
No one assigned
Labels
3. to review Waiting for reviews design Related to the design enhancement New feature or request
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@susnux @jotoeri @jancborchardt @mejo- @Chartman123