fix: cast allowComments to boolean#3381
Merged
Merged
Conversation
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Chartman123
added
3. to review
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Koc
approved these changes
Jun 5, 2026
timedin-de
pushed a commit
to timedin-de/forms
that referenced
this pull request
Jun 5, 2026
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
timedin-de
pushed a commit
to timedin-de/forms
that referenced
this pull request
Jun 5, 2026
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
timedin-de
pushed a commit
to timedin-de/forms
that referenced
this pull request
Jun 6, 2026
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue that Forms crashes on loading a newly created form. The db value for
allowCommentswasn't casted to(bool)and so it providednullas initial value. This couldn't be used asmodelValuefor theNcCheckboxRadioSwitchin the settings sidebar.Signed-off-by: Christian Hartmann chris-hartmann@gmx.de